improved documentation of Model::load() return value #9216
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @return boolean whether the model is successfully populated with some data. | ||
| * @return boolean whether `$data` contained some data to populate the models attributes. | ||
| * This does only mean that there was some data provided. It does not necessarily mean that any field | ||
| * was populated, which may be the case if none of the provided fields is safe in the current [[scenario]]. |
There was a problem hiding this comment.
It's good. But to make it more typical English, change "This does only mean that" to "This only means that"
There was a problem hiding this comment.
merged with adjustment. thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tried to make it more clear. @tom-- are you happy with this version?
fixes #8803