Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch api #4

Merged
merged 11 commits into from
Jul 8, 2023
Merged

Fetch api #4

merged 11 commits into from
Jul 8, 2023

Conversation

yin-ka
Copy link
Owner

@yin-ka yin-ka commented Jul 7, 2023

In this project, I have Successfully:

  • Create a new directory called components
  • Create a React component that matches the project design
  • Imported and used Components created.
  • Imported, initialized, and used states
  • Made use of use effect hooks
  • Updated Readme features section

Copy link

@Davidosky007 Davidosky007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @yin-ka 👋,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Highlights

  • API works well 👍
  • Data fetched properly 👍
  • Well written PR 👍

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@yin-ka yin-ka merged commit eaed532 into Dev Jul 8, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants