Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add loops #35

Merged
merged 5 commits into from
Jan 21, 2020
Merged

Add loops #35

merged 5 commits into from
Jan 21, 2020

Conversation

varkor
Copy link
Contributor

@varkor varkor commented Dec 17, 2018

This adds support for loops, as seen below.

image

Multiple loops are permitted on an object.

image

This is facilitated by a new "add loop" button that appears on hover.

image

There is also the option to rotate the loop through 90°. The loop direction can also be reversed.

image

Resolves #18.


I imagine there are probably some behaviours I've overlooked in the interaction with loops, so let me know if something doesn't seem natural, or doesn't work as expected.

@varkor varkor mentioned this pull request Dec 17, 2018
@varkor
Copy link
Contributor Author

varkor commented Dec 18, 2018

Note that this depends on yishn/jsx-tikzcd#5 to generate correct TikZ, so this will have to be updated before this is merged.

@yishn
Copy link
Owner

yishn commented Mar 1, 2019

@varkor I've published a new version of jsx-tikzcd with your changes and updated the dependencies. Can you resolve the conflicts, please?

@varkor
Copy link
Contributor Author

varkor commented Mar 2, 2019

I've rebased and fixed the conflicts.

@ScyllaHide ScyllaHide mentioned this pull request Apr 19, 2019
@ScyllaHide
Copy link

Is this now included in the new release, because I downloaded 0.60 and I can not find it?

@yishn
Copy link
Owner

yishn commented Apr 23, 2019

This is not merged yet, so it‘s not in the official release yet. I‘m super busy atm and I don’t know when I‘ll have the time to look over this...

@varkor
Copy link
Contributor Author

varkor commented Jan 20, 2020

@yishn: have you had a chance to look at this more recently?

@yishn
Copy link
Owner

yishn commented Jan 21, 2020

Thanks for the reminder! I've tested it out and it is lovely. ❤

@yishn yishn merged commit d9c31e1 into yishn:master Jan 21, 2020
@varkor
Copy link
Contributor Author

varkor commented Jan 21, 2020

@yishn: thank you very much, and thank you for developing tikzcd-editor — it's a really helpful and time-saving tool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loops
3 participants