Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support async #1

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: support async #1

wants to merge 4 commits into from

Conversation

yisibl
Copy link
Owner

@yisibl yisibl commented Nov 1, 2021

Upgrade napi-rs@2.0.0-alpha to support async.

@yisibl yisibl marked this pull request as draft November 1, 2021 07:13
@yisibl yisibl force-pushed the add-async branch 2 times, most recently from b6d81a3 to 0f9bb0b Compare November 15, 2021 11:32
src/lib.rs Outdated
type JsValue = Buffer;

fn compute(&mut self) -> Result<Self::Output> {
brotli_compress(self.data)
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Brooooooklyn 帮看看这里为啥提示报错了?

@Brooooooklyn
Copy link

需要 nightly 的 toolchain

@yisibl yisibl force-pushed the add-async branch 2 times, most recently from e54968e to f01b1da Compare November 15, 2021 14:43
@yisibl yisibl marked this pull request as ready for review November 17, 2021 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants