New: V1.0.0 Fixed #4

yisibl · Dec 3, 2018 · 5a649ef · 5a649ef
1 parent 23c6637
commit 5a649ef
Show file tree

Hide file tree

Showing 8 changed files with 24 additions and 6 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,7 @@
+# 1.0.0 - 2018-12-03
+* Updates to PostCSS 7
+* Allow double quotes to be used #4
+
 # 0.0.2 - 2017-07-12
 
 * Keep only padding-top

diff --git a/gulpfile.js b/gulpfile.js
@@ -16,6 +16,6 @@ gulp.task('test', function() {
 
 gulp.task('default', ['test'])
 
-gulp.task('watch', function () {
-    gulp.watch(files, ['test'])
+gulp.task('watch', function() {
+  gulp.watch(files, ['test'])
 })
diff --git a/index.js b/index.js
@@ -26,7 +26,7 @@ module.exports = postcss.plugin('postcss-layout', function(opts) {
 
 function processRatioValue(css, rule, decl) {
   var ratio = null
-  var re = /['']?(((?:\d*\.?\d*)?)(?:\:|\|)(\d+))['']?/g
+  var re = /[''""]?(((?:\d*\.?\d*)?)(?:\:|\|)(\d+))[''""]?/g
 
   ratio = decl.value
   ratio = ratio.replace(re, function(match, r, x, y) {

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "postcss-aspect-ratio-mini",
-  "version": "0.0.2",
+  "version": "1.0.0",
   "description": "A PostCSS plugin to fix an element's dimensions to an aspect ratio.",
   "main": "index.js",
   "scripts": {
@@ -26,11 +26,11 @@
   },
   "homepage": "https://github.com/yisibl/postcss-aspect-ratio-mini",
   "dependencies": {
-    "postcss": "^6.0.0"
+    "postcss": "^7.0.6"
   },
   "devDependencies": {
     "gulp": "^3.9.0",
-    "gulp-postcss": "^6.0.1",
+    "gulp-postcss": "^8.0.0",
     "gulp-shell": "^0.5.2",
     "gulp-tape": "0.0.7",
     "tap-diff": "^0.1.1",

diff --git a/test/fixtures/double-quote.actual.css b/test/fixtures/double-quote.actual.css
@@ -0,0 +1,3 @@
+.aspect-box:before {
+    padding-top: 56.25%
+}
diff --git a/test/fixtures/double-quote.css b/test/fixtures/double-quote.css
@@ -0,0 +1,3 @@
+.aspect-box {
+    aspect-ratio: "16:9";
+}
diff --git a/test/fixtures/double-quote.expected.css b/test/fixtures/double-quote.expected.css
@@ -0,0 +1,3 @@
+.aspect-box:before {
+    padding-top: 56.25%
+}
diff --git a/test/test.js b/test/test.js
@@ -32,3 +32,8 @@ test('damo', function(t) {
   compareFixtures(t, 'damo', 'should equal')
   t.end()
 })
+
+test('double-quote', function(t) {
+  compareFixtures(t, 'double-quote', 'should equal')
+  t.end()
+})