refactor: use urfave/cli instead of yitsushi/go-commander #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My CLI lib[^1] was a good exercise and an experiment[^2] 7 years ago. Back then, I did not plan to use it that long. I tried to keep the interface the same as it was before. Some changed, but I don't think anyone will notice as only `dump` and `import` changes. * The `import` command now requires an `--input` flag instead of a positional argument. * The `dump` command now required a `--yes-please` flag to make sure the user understands that the exported content will NOT be encrypted. * The `dump` command now requires an `--output` flag, stdout is not the default behaviour. If someone really wants to dump secrets to stdout... Well, you can use `--output=/dev/stdout`. Bug fixes: * Import did not import Prefix on overwrite. Closes #39 [^1]: https://github.com/yitsushi/go-commander [^2]: #78 (comment) Signed-off-by: Efertone <efertone@pm.me>
Signed-off-by: Efertone <efertone@pm.me>
|
This fixed #78 too 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My CLI lib1 was a good exercise and an experiment2 7 years ago. Back then, I did not plan to use it that long.
I tried to keep the interface the same as it was before. Some changed, but I don't think anyone will notice as only
dumpandimportchanges.importcommand now requires an--inputflag instead of a positional argument.dumpcommand now required a--yes-pleaseflag to make sure the user understands that the exported content will NOT be encrypted.dumpcommand now requires an--outputflag, stdout is not the default behaviour. If someone really wants to dump secrets to stdout... Well, you can use--output=/dev/stdout.Bug fixes:
Closes #39
Footnotes
https://github.com/yitsushi/go-commander ↩
https://github.com/yitsushi/totp-cli/issues/78#issuecomment-1639523393 ↩