Skip to content

Commit

Permalink
Revert "make LocalHistoryRoute a proper super-mixin (flutter#23382)" (f…
Browse files Browse the repository at this point in the history
…lutter#23430)

This reverts commit a3e0b0a.

This change broke the analyzer during the dartdoc step.
  • Loading branch information
yjbanov committed Oct 23, 2018
1 parent f7f7221 commit 3bbb308
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
8 changes: 5 additions & 3 deletions packages/flutter/lib/src/widgets/routes.dart
Original file line number Diff line number Diff line change
Expand Up @@ -306,14 +306,16 @@ class LocalHistoryEntry {
}
}

/// A mixin used by routes to handle back navigations internally by popping a list.
/// A route that can handle back navigations internally by popping a list.
///
/// When a [Navigator] is instructed to pop, the current route is given an
/// opportunity to handle the pop internally. A `LocalHistoryRoute` handles the
/// opportunity to handle the pop internally. A LocalHistoryRoute handles the
/// pop internally if its list of local history entries is non-empty. Rather
/// than being removed as the current route, the most recent [LocalHistoryEntry]
/// is removed from the list and its [LocalHistoryEntry.onRemove] is called.
mixin LocalHistoryRoute<T> on Route<T> {
///
/// This class is typically used as a mixin.
abstract class LocalHistoryRoute<T> extends Route<T> {
List<LocalHistoryEntry> _localHistory;

/// Adds a local history entry to this route.
Expand Down
2 changes: 1 addition & 1 deletion packages/flutter/test/widgets/routes_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ final List<String> results = <String>[];

Set<TestRoute> routes = HashSet<TestRoute>();

class TestRoute extends Route<String> with LocalHistoryRoute<String> {
class TestRoute extends LocalHistoryRoute<String> {
TestRoute(this.name);
final String name;

Expand Down

0 comments on commit 3bbb308

Please sign in to comment.