Revert "make LocalHistoryRoute a proper super-mixin (#23382)" #23430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a3e0b0a. This change broke the analyzer during the dartdoc step.
Xavjer
pushed a commit
to Xavjer/flutter
that referenced
this pull request
Oct 24, 2018
…lutter#23430) This reverts commit a3e0b0a. This change broke the analyzer during the dartdoc step.
yjbanov
added a commit
to yjbanov/flutter
that referenced
this pull request
Oct 24, 2018
…23382)" (flutter#23430)" This reverts commit 3bbb308. This relands the LocalHistoryRoute change. The analyzer bug has been fixed.
Xavjer
pushed a commit
to Xavjer/flutter
that referenced
this pull request
Nov 1, 2018
…23382)"… (flutter#23482) * Revert "Revert "make LocalHistoryRoute a proper super-mixin (flutter#23382)" (flutter#23430)" This reverts commit 3bbb308. This relands the LocalHistoryRoute change. The analyzer bug has been fixed. * mark dartdocs as flaky
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit a3e0b0a.
This change broke the analyzer during the dartdoc step.