After manual destruction, don't destroy again on model disposal

Signed-off-by: Andrew Haines <andrew@haines.org.nz>
yjs · Nov 2, 2023 · 7cecd51 · 7cecd51
1 parent 96a73c6
commit 7cecd51
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/src/y-monaco.js b/src/y-monaco.js
@@ -180,7 +180,7 @@ export class MonacoBinding {
         }, this)
       })
     })
-    monacoModel.onWillDispose(() => {
+    this._monacoDisposeHandler = monacoModel.onWillDispose(() => {
       this.destroy()
     })
     if (awareness) {
@@ -212,6 +212,7 @@ export class MonacoBinding {
 
   destroy () {
     this._monacoChangeHandler.dispose()
+    this._monacoDisposeHandler.dispose()
     this.ytext.unobserve(this._ytextObserver)
     this.doc.off('beforeAllTransactions', this._beforeTransaction)
     if (this.awareness) {