Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate json based state storage to something more reliable and faster like h2 #70

Closed
ylexus opened this issue Aug 12, 2020 · 2 comments
Closed

Migrate json based state storage to something more reliable and faster like h2 #70

ylexus opened this issue Aug 12, 2020 · 2 comments
Labels
good first issue Good for newcomers

Comments

@ylexus
Copy link
Owner

ylexus commented Aug 12, 2020

Currently, the whole VarStore (can be tens of Mb or more) is encoded to JSON and saved to disk on every file upload. This is inefficient. Also, couple of users experienced corrupted JSON files (for example, see https://github.com/ylexus/jiotty-photos-uploader/files/5062512/main.log.txt). Something like H2 is more suited for these needs.
@ylexus ylexus added the good first issue Good for newcomers label Aug 12, 2020
@ylexus
Copy link
Owner Author

ylexus commented Aug 12, 2020 •
edited
Loading

The advantage of keeping it in json is you could easily ask a user to send it to you for analysis and they could see inside it before sending to ensure they are not sending something super-confidential.

@ylexus ylexus mentioned this issue Oct 1, 2020
Closed
@ylexus ylexus mentioned this issue May 21, 2021
Closed
ylexus pushed a commit that referenced this issue May 21, 2021
#70 Migrate json based state storage to H2
efb17ac
ylexus pushed a commit that referenced this issue May 21, 2021
#70 fix migration failing if old and new storage have same keys
2976f3f
ylexus pushed a commit that referenced this issue May 21, 2021
#70 fix dependency
bb18c02
@ylexus
Copy link
Owner Author

ylexus commented May 21, 2021

Released in 1.9.0

@ylexus ylexus closed this as completed May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ylexus