Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: Option to add files from subfolders to main album #71

Closed
marcovanree opened this issue Aug 17, 2020 · 13 comments
Closed

FR: Option to add files from subfolders to main album #71

marcovanree opened this issue Aug 17, 2020 · 13 comments

Comments

@marcovanree
Copy link
Collaborator

photo folder

  • folder1
    • folder2
      • photo1.jpg
      • photo2.jpg
    • folder3
      • photo2.jpg
  • folder4

Like the example
all files in folder 1 including subfolders (folder2 and folder3) will be added to album "folder1"

In this case you will have 2 albums, Folder1 and Folder4

@ylexus
Copy link
Owner

ylexus commented Aug 17, 2020

Should be doable. I'm on a holiday at the moment. Will work on this when I come back and find free time.

@marcovanree
Copy link
Collaborator Author

Nice then i will wait for that option :)

@ylexus
Copy link
Owner

ylexus commented Sep 11, 2020

@marcovanree, will this work for you? In your example, it'll do what you want if you set this new option to "2". "1" is the root level, i.e. the "photo folder", "2" is the level of "folder1" and "folder4" etc.

It sounds like I'll also need some graphic/picture, or simply a link to the wiki, to explain how this works.

image

@marcovanree
Copy link
Collaborator Author

marcovanree commented Sep 11, 2020

  • folder1
    • folder2
      • photo1.jpg
      • photo2.jpg
    • folder3
      • photo3.jpg
      • folder4
        • photo4.jpg
  • folder5
    • photo5.jpg

So if i set it on 2, and if there is a root and photo folder then above example will create 2 albums ?
folder1 with images photo1.jpg, photo2.jpg, photo3.jpg, photo4.jpg and folder5 with image photo5.jpg ?

that's what i am looking for :)

If i point your program to the folder where all my album folders are, is it not easyer a checkbox include all subfolders from album folder ? But this works for me too, but maybe is that easyer to understand for users :)

@ylexus
Copy link
Owner

ylexus commented Sep 11, 2020

Yes, this is exactly what it will do.

Well, I could have a checkbox called "use only top level folders as albums" - this is definitely easier to understand, you are right. Still, some users will not understand anyway, I am sure :-). So I'll leave it as is and will have a link to the wiki with help. This whole thing is only for a very small amount of users.

@ylexus
Copy link
Owner

ylexus commented Sep 11, 2020

@marcovanree can you please:

  1. translate some new resources marked with #TODO translate to Dutch? They are new phrases to support this new functionality, as well as some previous omissions - there are not many of these.
  2. download this beta release https://github.com/ylexus/jiotty-photos-uploader/releases/tag/1.5.0-beta1 and test both this issue and FR: a CLI option to run the program with parameters #72? Please ignore the upgrade notification - I'll fix that later. The binary to run is /Applications/Jiotty\ Photos\ Uploader.app/Contents/MacOS/Jiotty\ Photos\ Uploader. If started without argument's it'll run a GUI. If started with at least one argument, it'll run a CLI. Add "-h" to get help on options. The CLI will use same preferences as GUI, i.e. to change preferences, run GUI, change preferences, and then the CLI will use them.
  3. let me know how it goes?

@axylee, can I please ask you again to translate phrases marked as #TODO translate to Chinese? Much appreciated.

ylexus pushed a commit that referenced this issue Sep 11, 2020
ylexus pushed a commit that referenced this issue Sep 11, 2020
@marcovanree
Copy link
Collaborator Author

Yes :) i'm going to test this

@ylexus
Copy link
Owner

ylexus commented Sep 14, 2020

Released in 1.5.0

@ylexus ylexus closed this as completed Sep 14, 2020
@ylexus ylexus reopened this Sep 14, 2020
@ylexus
Copy link
Owner

ylexus commented Sep 14, 2020

I'll leave it open for a while in case @axylee and @marcovanree you guys wanted to translate the new phrases :)

@marcovanree
Copy link
Collaborator Author

Works nice :D,
I have test this with different levels and works perfect.
Will make the translations tomorrow.

@ylexus
Copy link
Owner

ylexus commented Sep 24, 2020

@marcovanree @axylee would you be able to submit the translations - there are only a few new ones marked with #TODO. Thanks.

@marcovanree
Copy link
Collaborator Author

Sorry, I thought I already did :)

And 'Stop upload' is a good dutch translation :)

@ylexus
Copy link
Owner

ylexus commented Oct 1, 2020

@marcovanree thanks, released in 1.5.1

@ylexus ylexus closed this as completed Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants