Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle all keyboard interrupts more completely #28

Closed
wants to merge 2 commits into from
Closed

Handle all keyboard interrupts more completely #28

wants to merge 2 commits into from

Conversation

myint
Copy link
Contributor

@myint myint commented Aug 23, 2013

This fixes #27.

@ymattw
Copy link
Owner

ymattw commented Aug 24, 2013

Smart fix, thanks!

Please note cdiff does not work on Windows at all because it imports fcntl which only available on Unix platforms, that was introduced to support context diff via filterdiff (see #15). So I am going to cherry-pick 5cf5ab7 only. Let me know if anything I misunderstood.

@ymattw
Copy link
Owner

ymattw commented Aug 24, 2013

Cherry pick'ed 5cf5ab7, thanks.

@ymattw ymattw closed this Aug 24, 2013
myint added a commit to myint/cdiff that referenced this pull request Aug 30, 2013
@myint
Remove code made unnecessary by ymattw#28
d303247
ymattw added a commit that referenced this pull request Aug 30, 2013
@ymattw
Merge pull request #29 from myint/master
551350d 
Remove code made unnecessary by #28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Corrupted terminal
2 participants
@myint @ymattw