Branch Amenities: Closed Amenities #2015

vitalii-stepaniuk · 2020-05-18T16:29:55Z

This PR adds Closed Amenities field to Branch content type, displays amenities in two columns (Open and Closed amenities, if closed amenities exist), and adds a paragraph Branch Amenities that shows amenities with green check (open) and red cross (closed) icons.

Steps for review

Run updates.
Edit any branch and add closed amenities inside Branch Amenities fieldset.
Add Branch Amenities paragraph to the node.

gundevel · 2020-05-18T16:31:15Z

Can one of the admins verify this patch? Use "o+k to test" or ''t+est this please" for manual build execution.

anpolimus · 2020-05-18T21:05:40Z

modules/custom/openy_ckeditor/openy_ckeditor.module

+    $amenities_ids[] = $id['target_id'];
+  }
+  $amenities = \Drupal::service('entity_type.manager')
+    ->getStorage('taxonomy_term')


TaxonomyTerm::loadMultiple

…into YOPN-858

AndreyMaximov · 2020-05-19T10:30:48Z

ok to test

gundevel · 2020-05-19T10:39:55Z

Build comment file:

Check Open Y Installation Wizard at http://install.openy.cibox.tools/build2206/install.php

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://openy.cibox.tools:8080/job/PR_BUILDER_COMPOSER/2206/

gundevel · 2020-05-19T10:40:09Z

Acessibility Sniffer: front page checking WCAG2AA http://openy.cibox.tools/build2206/frontWCAG2AAhtmlcs.txt
Acessibility Sniffer: join page checking WCAG2AA http://openy.cibox.tools/build2206/joinWCAG2AAhtmlcs.txt
Acessibility Sniffer: locations page checking WCAG2AA http://openy.cibox.tools/build2206/locationsWCAG2AAhtmlcs.txt
Acessibility Sniffer: schedules page checking WCAG2AA http://openy.cibox.tools/build2206/schedulesWCAG2AAhtmlcs.txt
Acessibility Sniffer: blog page checking WCAG2AA http://openy.cibox.tools/build2206/blogWCAG2AAhtmlcs.txt

gundevel · 2020-05-19T11:06:29Z

Open Y Complete profile installed at http://openy.cibox.tools/build2206/

podarok

Small changes, please

podarok · 2020-05-19T12:11:26Z

.../openy_block_branch_amenities/config/install/paragraphs.paragraphs_type.branch_amenities.yml

+status: true
+dependencies: {  }
+_core:
+  default_config_hash: c4A5enOspH2lSRkObw2PzbZcD-ldXLpBO91Nk0F6Qas


it looks wrong. Hash should not be included in configs

podarok · 2020-05-19T12:11:39Z

...peny_block_branch_amenities/config/install/field.storage.paragraph.field_amenities_block.yml

+    - block_content
+    - paragraphs
+_core:
+  default_config_hash: n4KePQPN8a6yMnGHTR-lYrOMBMOUQXhNQ89Q80fLjjg


it looks wrong. Hash should not be included in configs

podarok · 2020-05-19T12:11:52Z

...ion/modules/openy_loc_branch/config/install/core.entity_view_display.node.branch.default.yml

@@ -26,11 +27,21 @@ dependencies:
    - openy_field_custom_hours
    - telephone
    - user
+_core:
+  default_config_hash: mRQJNhp4t6OSJSFQmOqvzFti_RolSTMMSKpRgcezXNE


it looks wrong. Hash should not be included in configs

podarok · 2020-05-19T12:12:26Z

.../openy_loc_branch/config/install/field.field.node.branch.field_location_amenities_closed.yml

+entity_type: node
+bundle: branch
+label: 'Closed Amenities'
+description: ''


can we have a business description everywhere?

podarok · 2020-05-19T12:12:40Z

...dules/openy_loc_branch/config/install/field.storage.node.field_location_amenities_closed.yml

+cardinality: -1
+translatable: true
+indexes: {  }
+persist_with_no_fields: false


always true, please

podarok · 2020-05-19T12:13:37Z

themes/openy_themes/openy_carnation/src/scss/paragraphs/_amenities.scss

+  box-shadow: 0 3px 30px 2px rgba(0, 0, 0, 0.05);
+  border-radius: 8px;
+  margin-bottom: 50px;
+  color: #4f4f4f;


can we use global _variables where all colors stored?

podarok · 2020-05-19T12:13:53Z

themes/openy_themes/openy_carnation/src/scss/paragraphs/_amenities.scss

+      font-family: $font-awesome;
+      font-weight: 900;
+      content: "\f00d";
+      color: #dc3545;


same here, global colors, please

vitalii-stepaniuk · 2020-05-19T13:17:46Z

@podarok The issues you've listed above are fixed now. Could you please review the PR again?
Thanks!

gundevel · 2020-05-19T13:20:26Z

Build comment file:

Check Open Y Installation Wizard at http://install.openy.cibox.tools/build2207/install.php

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://openy.cibox.tools:8080/job/PR_BUILDER_COMPOSER/2207/

gundevel · 2020-05-19T13:20:40Z

Acessibility Sniffer: front page checking WCAG2AA http://openy.cibox.tools/build2207/frontWCAG2AAhtmlcs.txt
Acessibility Sniffer: join page checking WCAG2AA http://openy.cibox.tools/build2207/joinWCAG2AAhtmlcs.txt
Acessibility Sniffer: locations page checking WCAG2AA http://openy.cibox.tools/build2207/locationsWCAG2AAhtmlcs.txt
Acessibility Sniffer: schedules page checking WCAG2AA http://openy.cibox.tools/build2207/schedulesWCAG2AAhtmlcs.txt
Acessibility Sniffer: blog page checking WCAG2AA http://openy.cibox.tools/build2207/blogWCAG2AAhtmlcs.txt

gundevel · 2020-05-19T13:46:22Z

Open Y Complete profile installed at http://openy.cibox.tools/build2207/

podarok · 2020-05-19T16:29:28Z

@vitalii-stepaniuk fix conflicts and this one ready to be merged

gundevel · 2020-05-19T17:05:04Z

Build comment file:

Check Open Y Installation Wizard at http://install.openy.cibox.tools/build2212/install.php

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://openy.cibox.tools:8080/job/PR_BUILDER_COMPOSER/2212/

gundevel · 2020-05-19T17:07:00Z

Acessibility Sniffer: front page checking WCAG2AA http://openy.cibox.tools/build2212/frontWCAG2AAhtmlcs.txt
Acessibility Sniffer: join page checking WCAG2AA http://openy.cibox.tools/build2212/joinWCAG2AAhtmlcs.txt
Acessibility Sniffer: locations page checking WCAG2AA http://openy.cibox.tools/build2212/locationsWCAG2AAhtmlcs.txt
Acessibility Sniffer: schedules page checking WCAG2AA http://openy.cibox.tools/build2212/schedulesWCAG2AAhtmlcs.txt
Acessibility Sniffer: blog page checking WCAG2AA http://openy.cibox.tools/build2212/blogWCAG2AAhtmlcs.txt

gundevel · 2020-05-19T17:32:24Z

Open Y Complete profile installed at http://openy.cibox.tools/build2212/

gundevel · 2020-05-20T06:57:56Z

Build comment file:

Check Open Y Installation Wizard at http://install.openy.cibox.tools/build2213/install.php

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://openy.cibox.tools:8080/job/PR_BUILDER_COMPOSER/2213/

gundevel · 2020-05-20T06:58:10Z

Acessibility Sniffer: front page checking WCAG2AA http://openy.cibox.tools/build2213/frontWCAG2AAhtmlcs.txt
Acessibility Sniffer: join page checking WCAG2AA http://openy.cibox.tools/build2213/joinWCAG2AAhtmlcs.txt
Acessibility Sniffer: locations page checking WCAG2AA http://openy.cibox.tools/build2213/locationsWCAG2AAhtmlcs.txt
Acessibility Sniffer: schedules page checking WCAG2AA http://openy.cibox.tools/build2213/schedulesWCAG2AAhtmlcs.txt
Acessibility Sniffer: blog page checking WCAG2AA http://openy.cibox.tools/build2213/blogWCAG2AAhtmlcs.txt

gundevel · 2020-05-20T07:23:06Z

Open Y Complete profile installed at http://openy.cibox.tools/build2213/

vitalii-stepaniuk added 4 commits May 18, 2020 15:48

YOPN-858: Added Closed Amenities field to Branch content type.

ece29c0

YOPN-858: Highlight amenity type title.

f347905

YOPN-858: Branch Amenities paragraph.

212a4a1

YOPN-858: Changed widget for branch amenities block field.

7c64627

Merge branch '8.x-2.x' into YOPN-858

082f7e5

anpolimus suggested changes May 18, 2020

View reviewed changes

anpolimus added IXM Assigned for resolution PR: Needs Review Needs someone review ( code ) labels May 18, 2020

vitalii-stepaniuk added 2 commits May 19, 2020 09:12

YOPN-858: Refactoring.

952f3d9

Merge branch 'YOPN-858' of https://github.com/vitalii-stepaniuk/openy …

6ea5067

…into YOPN-858

podarok suggested changes May 19, 2020

View reviewed changes

YOPN-858: Fixes after code review.

f537120

vitalii-stepaniuk requested review from podarok and anpolimus May 19, 2020 13:33

podarok added PR: Needs Work Unfinished task. Issues still there and removed PR: Needs Review Needs someone review ( code ) labels May 19, 2020

podarok previously approved these changes May 19, 2020

View reviewed changes

YOPN-858: Solved conflicts.

1a99b58

vitalii-stepaniuk dismissed podarok’s stale review via 1a99b58 May 19, 2020 16:58

podarok added PR: Code Reviewed Code reviewed. Ready for QA PR: Needs Testing Manual testing is needed Type: Enhancement Change request. New functionality. and removed PR: Needs Work Unfinished task. Issues still there labels May 20, 2020

Fixed conflicts.

b351645

podarok merged commit e040b5d into ymcatwincities:8.x-2.x May 20, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Branch Amenities: Closed Amenities #2015

Branch Amenities: Closed Amenities #2015

vitalii-stepaniuk commented May 18, 2020 •

edited

Loading

gundevel commented May 18, 2020

anpolimus May 18, 2020

vitalii-stepaniuk May 19, 2020

AndreyMaximov commented May 19, 2020

gundevel commented May 19, 2020

gundevel commented May 19, 2020

gundevel commented May 19, 2020

podarok left a comment

podarok May 19, 2020

podarok May 19, 2020

podarok May 19, 2020

podarok May 19, 2020

podarok May 19, 2020

podarok May 19, 2020

podarok May 19, 2020

vitalii-stepaniuk commented May 19, 2020

gundevel commented May 19, 2020

gundevel commented May 19, 2020

gundevel commented May 19, 2020

podarok commented May 19, 2020

gundevel commented May 19, 2020

gundevel commented May 19, 2020

gundevel commented May 19, 2020

gundevel commented May 20, 2020

gundevel commented May 20, 2020

gundevel commented May 20, 2020

Branch Amenities: Closed Amenities #2015

Branch Amenities: Closed Amenities #2015

Conversation

vitalii-stepaniuk commented May 18, 2020 • edited Loading

Steps for review

gundevel commented May 18, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AndreyMaximov commented May 19, 2020

gundevel commented May 19, 2020

Build comment file:

gundevel commented May 19, 2020

gundevel commented May 19, 2020

podarok left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vitalii-stepaniuk commented May 19, 2020

gundevel commented May 19, 2020

Build comment file:

gundevel commented May 19, 2020

gundevel commented May 19, 2020

podarok commented May 19, 2020

gundevel commented May 19, 2020

Build comment file:

gundevel commented May 19, 2020

gundevel commented May 19, 2020

gundevel commented May 20, 2020

Build comment file:

gundevel commented May 20, 2020

gundevel commented May 20, 2020

vitalii-stepaniuk commented May 18, 2020 •

edited

Loading