This repository has been archived by the owner on Jul 1, 2022. It is now read-only.
Return default Focal Point behavior if no paragraph type or field in query params. #2404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…query params. Our custom Focal Point widget (combined with manual Crop) supports only images in paragraph entities. And in order to keep the Focal Point functionality working on images used in other places - we need to fallback to the default behavior if there were no paragraph type / field name in query args.
|
Can one of the admins verify this patch? Use "o+k to test" or ''t+est this please" for manual build execution. |
podarok
approved these changes
Feb 20, 2021
|
ok to test |
Build comment file:Check Open Y Installation Wizard at http://install.openy.cibox.tools/build3097/install.php Test PASSed. |
|
Open Y Upgrade Path site check installed at http://upgrade.openy.cibox.tools/build3097/ |
podarok
added
dependencies
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our custom Focal Point widget (combined with manual Crop) supports only images in paragraph entities. And in order to keep the Focal Point functionality working on images used in other places - we need to fallback to the default behavior if there were no paragraph type / field name in query args.
Test steps: