Skip to content
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.

Add custom query options to Save button of media image edit form. #2432

Merged
merged 1 commit into from
Apr 6, 2021

Conversation

duozersk
Copy link
Contributor

@duozersk duozersk commented Apr 5, 2021

This is a follow-up to #2404 - it fixed the Focal Point for images directly attached as fields to the nodes, but have broken the Focal Point saving process for the images in paragraphs.
This PR adds the same query params used by our custom widget to the media edit form Save button so that saving this media item doesn't over-write the Focal Point set by our custom processing.

Steps to reproduce:

  • login as admin
  • edit any content with paragraphs, like Landing Page
  • add/edit any paragraph with image reference that is using "OpenY Entity Browser", for instance, Banner
  • edit the image (it should open another modal with Media edit form) - this Image edit form uses the "OpenY Image (Focal Point)" widget, which allows to set Focal Point and Manual Crop in separate forms
  • set focal point and save it (it successfully saves); close the Focal Point modal
  • then Save the Image edit form - (before the patch: this Save will over-write the Focal Point set above ^^)
  • edit the same image again, verify the Focal Point is still there you set it
  • before the patch - it will reset to the center of the image
  • after the patch - it will be there where you set it

Related configuration screens:
image
image
image

@gundevel
Copy link
Collaborator

gundevel commented Apr 5, 2021

Can one of the admins verify this patch? Use "o+k to test" or ''t+est this please" for manual build execution.

@podarok
Copy link
Contributor

podarok commented Apr 5, 2021

Any steps.for review or/and issue context? @duozersk

@duozersk
Copy link
Contributor Author

duozersk commented Apr 5, 2021

@podarok I have updated the PR description.

@podarok podarok added the Type: Bug Bug. Something is not working as intended. label Apr 6, 2021
@podarok
Copy link
Contributor

podarok commented Apr 6, 2021

ok to test

@gundevel
Copy link
Collaborator

gundevel commented Apr 6, 2021

Build comment file:

Check Open Y Installation Wizard at http://install.openy.cibox.tools/build3131/install.php


Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://openy.cibox.tools:8080/job/PR_BUILDER_COMPOSER/3131/

@gundevel
Copy link
Collaborator

gundevel commented Apr 6, 2021

Open Y Upgrade Path site check installed at http://upgrade.openy.cibox.tools/build3131/

@podarok podarok merged commit b2460a1 into ymcatwincities:9.x-2.x Apr 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: Bug Bug. Something is not working as intended.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants