Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update youneedabudget.com references to ynab.com #67

Merged
merged 2 commits into from Apr 4, 2023
Merged

Conversation

bradymholt
Copy link
Member

@bradymholt bradymholt commented Mar 6, 2023

Update youneedabudget.com references to ynab.com.

@bradymholt bradymholt marked this pull request as ready for review April 3, 2023 20:48
@bradymholt bradymholt requested a review from dbertram April 3, 2023 20:48
Copy link
Member

@dbertram dbertram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For my own edification, are the rest of the references to youneedabudget.com all updated during the rake generate task that runs via CI?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's one additional reference in the comment on line 6 (I tried to push the update myself, but I don't have access to this repo)...or does that get pulled in from the swagger file as well?

Copy link
Member Author

@bradymholt bradymholt Apr 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's right. I am planning on regenerating from the latest spec, after merging this, and that would update all the references in the generated file. But, there is no reason I can't do that as part of this PR. I ran rake generate and committed change here: 3901b5d.

That should have changed line 6 in ynab.gemspec along with all the other references.

@bradymholt bradymholt merged commit 327b5af into main Apr 4, 2023
1 check passed
@bradymholt bradymholt deleted the ynab-com branch April 4, 2023 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants