Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blender: Extract Review #3616

Merged
merged 10 commits into from
Mar 17, 2023
Merged

Blender: Extract Review #3616

merged 10 commits into from
Mar 17, 2023

Conversation

simonebarbieri
Copy link
Member

Brief description

Added Review to Blender.

Description

This implementation is based on #3508 but made compatible for the current implementation of OpenPype for Blender.

@simonebarbieri simonebarbieri added host: Blender type: feature Larger, user affecting changes and completely new things labels Aug 4, 2022
@simonebarbieri simonebarbieri self-assigned this Aug 4, 2022
LiborBatek
LiborBatek approved these changes Oct 14, 2022
View reviewed changes
Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything working fine...published model and review ok.
image

@LiborBatek
Copy link
Member

Just a small note, the video doesnt have any burnins like maya one (author, version, date etc.) so not sure how it suppose to work in blender and/or how its created in...

@simonebarbieri simonebarbieri marked this pull request as ready for review January 9, 2023 16:21
@m-u-r-p-h-y
Copy link
Member

Just a small note, the video doesnt have any burnins like maya one (author, version, date etc.) so not sure how it suppose to work in blender and/or how its created in...

It is done by a different plugin - Extract burnins

image

mkolar
mkolar previously requested changes Jan 10, 2023
View reviewed changes
Copy link
Member

@mkolar mkolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a syntax error in the default blender settings. That means that you probably created the defaults manually rather than using the developer mode in the settings GUI. Please use it every time you create a new settings to prevent this from happening.
image

Secondly, it looks like you still have OCIO configs submodule in your branch, however, it was removed in the upstream and this PR is trying to get it back. Please remove it before we merge this.

LiborBatek
LiborBatek approved these changes Jan 11, 2023
View reviewed changes
Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All works fine.
image

iLLiCiTiT
iLLiCiTiT approved these changes Mar 6, 2023
View reviewed changes
Copy link
Member

@iLLiCiTiT iLLiCiTiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks ok.

@antirotor antirotor merged commit b45a907 into ynput:develop Mar 17, 2023
@ynbot ynbot added this to the next-patch milestone Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antirotor antirotor antirotor approved these changes

@iLLiCiTiT iLLiCiTiT iLLiCiTiT approved these changes

@LiborBatek LiborBatek LiborBatek approved these changes

@mkolar mkolar Awaiting requested review from mkolar

Assignees

@simonebarbieri simonebarbieri

Labels
host: Blender type: feature Larger, user affecting changes and completely new things
Projects
None yet
Milestone
3.15.3
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@simonebarbieri @LiborBatek @m-u-r-p-h-y @mkolar @antirotor @iLLiCiTiT @ynbot