Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Blender: Review (feature from extracted code of the Maya Review) #3508

Closed

Conversation

kaamaurice
Copy link
Contributor

Brief description

Added Review features as Maya.

Description

The feature is base on the review process from Maya.

  • Creator for the Review container
  • Collect_Review use Extract_Playblast at publishing if asset have a Review container.
  • Extract_Thumbnail at publishing, if asset have Review container or for all tasks Model and Rigging.

Discussion : https://github.com/pypeclub/OpenPype/discussions/3423

Rebased with branch in PR: #3463

@ynbot
Copy link
Contributor

ynbot commented Jul 13, 2022

Task linked: OP-3423 Fix linking static assets

@kaamaurice kaamaurice force-pushed the feature/OP-3423_Blender-review branch 2 times, most recently from 4fff0ea to 27d3bbd Compare August 3, 2022 15:46
@kaamaurice kaamaurice force-pushed the feature/OP-3423_Blender-review branch from 21fff6b to 4c92343 Compare August 4, 2022 09:58
@kaamaurice kaamaurice force-pushed the feature/OP-3423_Blender-review branch 2 times, most recently from a53ee92 to 2afa8a2 Compare August 10, 2022 15:01
@kaamaurice kaamaurice force-pushed the feature/OP-3423_Blender-review branch from 2afa8a2 to 38d8e49 Compare August 16, 2022 09:49
@kaamaurice kaamaurice force-pushed the feature/OP-3423_Blender-review branch 4 times, most recently from 54e84eb to a051f0a Compare August 25, 2022 10:16
Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review works fine in Blender 3.2.1 both for model and rig publish...


class SaveDirtyTextures(pyblish.api.Action):
"""Saves all dirty textures found"""

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blank line contains whitespace

if containers:
action().process(containers)

class SaveDirtyTextures(pyblish.api.Action):
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

expected 2 blank lines, found 1

@kaamaurice kaamaurice force-pushed the feature/OP-3423_Blender-review branch 2 times, most recently from a65c7a1 to 1eeb257 Compare October 6, 2022 13:55
@kaamaurice kaamaurice force-pushed the feature/OP-3423_Blender-review branch 3 times, most recently from 8ec242c to 621a74f Compare October 24, 2022 15:08
invalid.append(v)

return invalid

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blank line contains whitespace

from openpype.api import ValidateContentsOrder
from openpype.hosts.blender.api.action import SaveDirtyTextures

class ValidateNoDirtyTexture(pyblish.api.InstancePlugin):
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

expected 2 blank lines, found 1

)

frame_collection = collections[0]
self.log.info(f"We found collection of interest {frame_collection}")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line too long (80 > 79 characters)

@github-actions github-actions bot added this to the next-patch milestone Oct 28, 2022
@kaamaurice kaamaurice force-pushed the feature/OP-3423_Blender-review branch 2 times, most recently from 16129ed to 0f94b3f Compare November 3, 2022 15:23
@jakubjezek001 jakubjezek001 removed this from the next-patch milestone Nov 10, 2022
@kaamaurice kaamaurice closed this Mar 6, 2023
@ynbot ynbot added this to the next-patch milestone Mar 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants