-
Notifications
You must be signed in to change notification settings - Fork 129
Blender: Review (feature from extracted code of the Maya Review) #3508
Blender: Review (feature from extracted code of the Maya Review) #3508
Conversation
Task linked: OP-3423 Fix linking static assets |
4fff0ea
to
27d3bbd
Compare
21fff6b
to
4c92343
Compare
a53ee92
to
2afa8a2
Compare
2afa8a2
to
38d8e49
Compare
54e84eb
to
a051f0a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review works fine in Blender 3.2.1 both for model and rig publish...
46c3288
to
c611b08
Compare
|
||
class SaveDirtyTextures(pyblish.api.Action): | ||
"""Saves all dirty textures found""" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
blank line contains whitespace
if containers: | ||
action().process(containers) | ||
|
||
class SaveDirtyTextures(pyblish.api.Action): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
expected 2 blank lines, found 1
a65c7a1
to
1eeb257
Compare
8ec242c
to
621a74f
Compare
invalid.append(v) | ||
|
||
return invalid | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
blank line contains whitespace
from openpype.api import ValidateContentsOrder | ||
from openpype.hosts.blender.api.action import SaveDirtyTextures | ||
|
||
class ValidateNoDirtyTexture(pyblish.api.InstancePlugin): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
expected 2 blank lines, found 1
) | ||
|
||
frame_collection = collections[0] | ||
self.log.info(f"We found collection of interest {frame_collection}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
line too long (80 > 79 characters)
16129ed
to
0f94b3f
Compare
0f14138
to
2c3767d
Compare
Brief description
Added Review features as Maya.
Description
The feature is base on the review process from Maya.
Discussion : https://github.com/pypeclub/OpenPype/discussions/3423
Rebased with branch in PR: #3463