Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Locally copied version of last published workfile is not incremented #4102

Closed
wants to merge 25 commits into from
Closed

Fix: Locally copied version of last published workfile is not incremented #4102

wants to merge 25 commits into from
+242 −49

Commits on Mar 15, 2023

  1. Fix: Locally copied version of last published workfile is not increme… 

    …nted
    @Tilix4
    Tilix4 committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    96641a4 View commit details
    Browse the repository at this point in the history

  2. fix subset first match

    @Tilix4
    Tilix4 committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    ea39437 View commit details
    Browse the repository at this point in the history

  3. correct anatomy name

    @Tilix4
    Tilix4 committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    4fc1110 View commit details
    Browse the repository at this point in the history

  4. Fix typo and linting

    @Tilix4
    Tilix4 committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    40e3056 View commit details
    Browse the repository at this point in the history

  5. keep source filepath for further path conformation

    @Tilix4
    Tilix4 committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    d123fa0 View commit details
    Browse the repository at this point in the history

  6. fetch also input dependencies of workfile

    @Tilix4
    Tilix4 committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    ba96507 View commit details
    Browse the repository at this point in the history

  7. required changes

    @Tilix4
    Tilix4 committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    a295751 View commit details
    Browse the repository at this point in the history

  8. lint

    @Tilix4
    Tilix4 committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    12ec9ee View commit details
    Browse the repository at this point in the history

  9. fix case only one subset

    @Tilix4
    Tilix4 committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    533d5e5 View commit details
    Browse the repository at this point in the history

  10. Enhancement: copy last workfile as reusable methods (#6) 

    * Enhancement: copy last published workfile as reusable methods (WiP)

* Added get_host_extensions method, added subset_id and las_version_doc access, added optional arguments to get_last_published_workfile

* Plugged in the new methods + minor changes

* Added docstrings, last workfile optional argument, and removed unused code

* Using new implementation to get local workfile path. Warning: It adds an extra dot to the extension which I need to fix

* Refactoring and fixed double dots

* Added match subset_id and get representation method, plus clan up

* Removed unused vars

* Fixed some rebasing errors

* delinted unchanged code and renamed get_representation into get_representation_with_task

* This time it's really delinted, I hope...

* Update openpype/modules/sync_server/sync_server.py

reprenation isn't the right spelling (:

Co-authored-by: Félix David <felixg.david@gmail.com>

* Changes based on reviews

* Fixed non imperative docstring and missing space

* Fixed another non imperative docstring

* Update openpype/modules/sync_server/sync_server.py

Fixed typo

Co-authored-by: Félix David <felixg.david@gmail.com>

Co-authored-by: Hayley GUILLOT <hayleyguillot@outlook.com>
Co-authored-by: Félix David <felixg.david@gmail.com>
    @Sharkitty @Tilix4
    3 people committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    6ea3f51 View commit details
    Browse the repository at this point in the history

  11. Fix: syntax error

    @Tilix4
    Tilix4 committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    0947b0a View commit details
    Browse the repository at this point in the history

  12. fix single subset case

    @Tilix4
    Tilix4 committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    d962b26 View commit details
    Browse the repository at this point in the history

  13. Restore sync server enabled test in hook

    @Tilix4
    Tilix4 committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    b3409a7 View commit details
    Browse the repository at this point in the history

  14. Python2 syntax

    @Tilix4
    Tilix4 committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    f03fecc View commit details
    Browse the repository at this point in the history

  15. renaming and missing key case handling

    @Tilix4
    Tilix4 committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    880e0f2 View commit details
    Browse the repository at this point in the history

  16. Fix local workfile overwritten on update in some cases (#7) 

    * Fix: Local workfile overwrite when local version number is higher than published workfile version number (WiP)

* Changed regex search, clean up

* Readded mistakenly removed newline
    @Sharkitty @Tilix4
    Sharkitty authored and Tilix4 committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    608da47 View commit details
    Browse the repository at this point in the history

  17. lint

    @Tilix4
    Tilix4 committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    cd15325 View commit details
    Browse the repository at this point in the history

  18. remove anticipated functions for cleaner PR

    @Tilix4
    Tilix4 committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    f066139 View commit details
    Browse the repository at this point in the history

  19. remove funcs from entities.py

    @Tilix4
    Tilix4 committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    bd7b590 View commit details
    Browse the repository at this point in the history

  20. change to get_last_workfile_with_version

    @Tilix4
    Tilix4 committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    b9660be View commit details
    Browse the repository at this point in the history

  21. clean

    @Tilix4
    Tilix4 committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    743288f View commit details
    Browse the repository at this point in the history

  22. Update openpype/modules/sync_server/sync_server.py 

    Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
    @Tilix4 @iLLiCiTiT
    Tilix4 and iLLiCiTiT committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    dc5a1c9 View commit details
    Browse the repository at this point in the history

  23. removed get_last_published_workfile_path

    @Tilix4
    Tilix4 committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    d4c066a View commit details
    Browse the repository at this point in the history

  24. moved hook to sync server module

    @Tilix4
    Tilix4 committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    1b32015 View commit details
    Browse the repository at this point in the history

  25. fix lint

    @Tilix4
    Tilix4 committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    37f618e View commit details
    Browse the repository at this point in the history