Fix: Locally copied version of last published workfile is not incremented #4102

Tilix4 · 2022-11-16T15:53:50Z

Fix 1

When copied, the local workfile version keeps the published version number, when it must be +1 to follow OP's naming convention.

Fix 2

Local workfile version's name is built from anatomy. This avoids to get workfiles with their publish template naming.

Fix 3

In the case a subset has at least two tasks with published workfiles, for example Modeling and Rigging, launching Rigging was getting the first one with the next and trying to find representations, therefore workfileModeling and trying to match the current task_name (Rigging) with the representation["context"]["task"]["name"] of a Modeling representation, which was ending up to a workfile_representation to None, and exiting the process.

Trying to find the task_name in the subset['name'] fixes it.

Fix 4

Fetch input dependencies of workfile.

iLLiCiTiT · 2022-11-16T15:59:44Z

Shouldn't the copied file actually have version 1?

Tilix4 · 2022-11-16T16:05:35Z

Shouldn't the copied file actually have version 1?

Actually it's very confusing for users when the local version don't match the published ones.

kalisp · 2022-11-16T16:05:54Z

@iLLiCiTiT I don't think so, why? But I agree with @Tilix4 , I tested that it takes latest published workfile, but forgot that Pyblish versions up automatically after publish.

iLLiCiTiT · 2022-11-16T16:16:12Z

Am I wrong that the prelaunch hook is actually creating first workfile if there is not any? So it is actually creating first workfile version... ?

Tilix4 · 2022-11-16T16:21:35Z

Am I wrong that the prelaunch hook is actually creating first workfile if there is not any? So it is actually creating first workfile version... ?

No you'are not, but it is very confusing if you know that 9 versions have been published and when opening the last one, you get a v001, but with the content of the v009 🤯

iLLiCiTiT · 2022-11-16T16:39:25Z

Ok but in case a workfile template should be used instead of just copying the file as is.

Tilix4 · 2022-11-16T16:44:38Z

Ok but in case a workfile template should be used instead of just copying the file as is.

Isn't it handled by the workfile template hook?

Tilix4 · 2022-11-17T10:47:44Z

In fact, it should use the Save as code and correcting the version number, because when copied it has the name of the published one and not the naming template of the workfile.

Tilix4 · 2022-11-17T15:12:49Z

Also added a fix: in the case a subset has at least two tasks with published workfiles, for example Modeling and Rigging, launching Rigging was getting the first one with the next and trying to find representations, therefore workfileModeling and trying to match the current task_name (Rigging) with the representation["context"]["task"]["name"] of a Modeling representation, which was ending up to a workfile_representation to None, and exiting the process.

Trying to find the task_name in the subset['name'] fixes it.

openpype/hooks/pre_copy_last_published_workfile.py

openpype/client/entities.py

iLLiCiTiT · 2022-12-05T18:15:15Z

openpype/client/entities.py

@@ -1032,6 +1079,31 @@ def get_representation_by_name(
    return conn.find_one(query_filter, _prepare_fields(fields))


+def get_representation_by_task(


I have similar issues with this function as with match_subset_id. It make sense only in very specific use-cases and since it is in fact just a filtering function I don't see a benefit to have it in public api for entities.

@Sharkitty Are you using this one in #4176 ?

Yes, it's called in the DownloadLastWorkfile Operator.

The DownloadLastWorkfile is fully dependent on sync server so if the functions are moved to sync server it should not block it.

Is it what we are supposed to do? Moving get_representation_by_task and get_matching_subset_id to sync_server.py

openpype/hooks/pre_copy_last_published_workfile.py

LiborBatek · 2022-12-12T07:58:23Z

@Tilix4 opps. thanks, my bad! you are right!

iLLiCiTiT · 2023-01-19T10:11:04Z

openpype/modules/sync_server/sync_server.py

+    )
+
+    # Get local workfile version number
+    last_local_workfile_version = None


There is function get_last_workfile_with_version in openpype.pipeline.workfile which does exactly this.

Changed with get_last_workfile_with_version

iLLiCiTiT · 2023-02-14T15:45:55Z

openpype/modules/sync_server/sync_server.py

@@ -229,6 +244,203 @@ def _get_configured_sites_from_setting(module, project_name, project_setting):
    return configured_sites


+def get_last_published_workfile_path(


There is too much arguments in this function. Also I'm not sure if it should be a function?
At the end its just this

path = None if workfile_representation: path = get_representation_path_with_anatomy( workfile_representation, anatomy )

openpype/modules/sync_server/sync_server.py

iLLiCiTiT · 2023-02-14T15:51:35Z

I would move the hook to sync server module.

…nted

* Enhancement: copy last published workfile as reusable methods (WiP) * Added get_host_extensions method, added subset_id and las_version_doc access, added optional arguments to get_last_published_workfile * Plugged in the new methods + minor changes * Added docstrings, last workfile optional argument, and removed unused code * Using new implementation to get local workfile path. Warning: It adds an extra dot to the extension which I need to fix * Refactoring and fixed double dots * Added match subset_id and get representation method, plus clan up * Removed unused vars * Fixed some rebasing errors * delinted unchanged code and renamed get_representation into get_representation_with_task * This time it's really delinted, I hope... * Update openpype/modules/sync_server/sync_server.py reprenation isn't the right spelling (: Co-authored-by: Félix David <felixg.david@gmail.com> * Changes based on reviews * Fixed non imperative docstring and missing space * Fixed another non imperative docstring * Update openpype/modules/sync_server/sync_server.py Fixed typo Co-authored-by: Félix David <felixg.david@gmail.com> Co-authored-by: Hayley GUILLOT <hayleyguillot@outlook.com> Co-authored-by: Félix David <felixg.david@gmail.com>

* Fix: Local workfile overwrite when local version number is higher than published workfile version number (WiP) * Changed regex search, clean up * Readded mistakenly removed newline

Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>

kalisp · 2023-03-29T11:26:39Z

Replaced by #4722

Tilix4 force-pushed the fx_auto_dl_workfile_version_up branch from 5457580 to 30895bd Compare November 17, 2022 15:07

iLLiCiTiT reviewed Nov 18, 2022

View reviewed changes

openpype/hooks/pre_copy_last_published_workfile.py Outdated Show resolved Hide resolved

iLLiCiTiT reviewed Nov 18, 2022

View reviewed changes

openpype/hooks/pre_copy_last_published_workfile.py Outdated Show resolved Hide resolved

This was referenced Dec 5, 2022

Draft: Feature: Handling workfile out of date in blender #4175

Closed

Draft: Feature: Handling out of date workfiles in Blender #4176

Closed

mkolar requested a review from LiborBatek December 5, 2022 15:50

iLLiCiTiT reviewed Dec 5, 2022

View reviewed changes

openpype/client/entities.py Outdated Show resolved Hide resolved

iLLiCiTiT reviewed Dec 5, 2022

View reviewed changes

openpype/hooks/pre_copy_last_published_workfile.py Show resolved Hide resolved

antirotor assigned Tilix4 Dec 7, 2022

antirotor added the type: enhancement Enhancements to existing functionality label Dec 7, 2022

Tilix4 force-pushed the fx_auto_dl_workfile_version_up branch from 8a4fe16 to 26cccd7 Compare December 9, 2022 08:01

ynput deleted a comment from Tilix4 Dec 12, 2022

mkolar added the community contribution label Jan 19, 2023

iLLiCiTiT reviewed Jan 19, 2023

View reviewed changes

iLLiCiTiT requested a review from kalisp January 19, 2023 10:12

iLLiCiTiT reviewed Feb 14, 2023

View reviewed changes

openpype/modules/sync_server/sync_server.py Outdated Show resolved Hide resolved

Fix: Locally copied version of last published workfile is not increme…

96641a4

…nted

Tilix4 and others added 22 commits March 15, 2023 09:16

Fix typo and linting

40e3056

keep source filepath for further path conformation

d123fa0

fetch also input dependencies of workfile

ba96507

required changes

a295751

lint

12ec9ee

fix case only one subset

533d5e5

Fix: syntax error

0947b0a

fix single subset case

d962b26

Restore sync server enabled test in hook

b3409a7

Python2 syntax

f03fecc

renaming and missing key case handling

880e0f2

Fix local workfile overwritten on update in some cases (#7)

608da47

* Fix: Local workfile overwrite when local version number is higher than published workfile version number (WiP) * Changed regex search, clean up * Readded mistakenly removed newline

lint

cd15325

remove anticipated functions for cleaner PR

f066139

remove funcs from entities.py

bd7b590

change to get_last_workfile_with_version

b9660be

clean

743288f

Update openpype/modules/sync_server/sync_server.py

dc5a1c9

Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>

removed get_last_published_workfile_path

d4c066a

moved hook to sync server module

1b32015

fix lint

37f618e

Tilix4 force-pushed the fx_auto_dl_workfile_version_up branch from 06083ba to 37f618e Compare March 15, 2023 08:16

kalisp assigned kalisp and unassigned Tilix4 Mar 24, 2023

kalisp mentioned this pull request Mar 28, 2023

Fix: Locally copied version of last published workfile is not incremented #4722

Merged

kalisp closed this Mar 29, 2023

ynbot added this to the next-patch milestone Mar 29, 2023

jakubjezek001 removed this from the next-patch milestone Mar 30, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: Locally copied version of last published workfile is not incremented #4102

Fix: Locally copied version of last published workfile is not incremented #4102

Tilix4 commented Nov 16, 2022 •

edited

iLLiCiTiT commented Nov 16, 2022

Tilix4 commented Nov 16, 2022

kalisp commented Nov 16, 2022

iLLiCiTiT commented Nov 16, 2022

Tilix4 commented Nov 16, 2022 •

edited

iLLiCiTiT commented Nov 16, 2022

Tilix4 commented Nov 16, 2022

Tilix4 commented Nov 17, 2022 •

edited

Tilix4 commented Nov 17, 2022

iLLiCiTiT Dec 5, 2022

Tilix4 Dec 6, 2022

Sharkitty Dec 6, 2022

iLLiCiTiT Dec 7, 2022

Tilix4 Dec 9, 2022 •

edited

LiborBatek commented Dec 12, 2022

iLLiCiTiT Jan 19, 2023

Tilix4 Jan 25, 2023

iLLiCiTiT Feb 14, 2023

Tilix4 Mar 15, 2023

iLLiCiTiT commented Feb 14, 2023

kalisp commented Mar 29, 2023

		@@ -1032,6 +1079,31 @@ def get_representation_by_name(
		return conn.find_one(query_filter, _prepare_fields(fields))


		def get_representation_by_task(

		@@ -229,6 +244,203 @@ def _get_configured_sites_from_setting(module, project_name, project_setting):
		return configured_sites


		def get_last_published_workfile_path(

Fix: Locally copied version of last published workfile is not incremented #4102

Fix: Locally copied version of last published workfile is not incremented #4102

Conversation

Tilix4 commented Nov 16, 2022 • edited

Fix 1

Fix 2

Fix 3

Fix 4

iLLiCiTiT commented Nov 16, 2022

Tilix4 commented Nov 16, 2022

kalisp commented Nov 16, 2022

iLLiCiTiT commented Nov 16, 2022

Tilix4 commented Nov 16, 2022 • edited

iLLiCiTiT commented Nov 16, 2022

Tilix4 commented Nov 16, 2022

Tilix4 commented Nov 17, 2022 • edited

Tilix4 commented Nov 17, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Tilix4 Dec 9, 2022 • edited

Choose a reason for hiding this comment

LiborBatek commented Dec 12, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

iLLiCiTiT commented Feb 14, 2023

kalisp commented Mar 29, 2023

Tilix4 commented Nov 16, 2022 •

edited

Tilix4 commented Nov 16, 2022 •

edited

Tilix4 commented Nov 17, 2022 •

edited

Tilix4 Dec 9, 2022 •

edited