Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maya: Fix validate frame range repair + fix create render with deadline disabled #4279

Merged
merged 4 commits into from Jan 6, 2023

Conversation

BigRoy
Copy link
Collaborator

@BigRoy BigRoy commented Jan 4, 2023

Brief description

This fixes:

Testing notes:

  1. Test Create Render with Deadline module disabled and with it enabled in a scene that does not yet have a renderingMain globals.
  2. Check with different start+end frame + handles settings for an asset on renderlayers, but also on other instances like pointcaches and cameras.

@LiborBatek
Copy link
Member

LiborBatek commented Jan 5, 2023

Did a first run of tests with creating Render subset.

All works when creating render subset... when deadline is on and off.

So no issues found on Test (1)

@LiborBatek
Copy link
Member

Test 02 - different frame start / end + frame handles setting and repair action

The repair action works on subsets (camera, review, animation etc) but it just set frame start and frame end according to absolute frame range as in DB (range + handles together) which sort of works but it doesnt respect the handle values in DB and the repair action doesnt put these values in. It behaves as in this PR #4272 aka same issue. So question is:
is it desirable to maintain frame start/end and frame handle start/end values exactly (as in DB) or just we care about absolute frame range so they match overall (maya scene / DB)

Another issue with repair action is when used on renderLayer and frame range overrides...it just fails and gives this error msg:
image

Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls see comments, needs change doesnt work as expected.

@BigRoy
Copy link
Collaborator Author

BigRoy commented Jan 5, 2023

@LiborBatek I'm pretty sure you were NOT running those tests on the code in this PR but were running it on a different branch. The line numbers in the error of your first screenshot here refer to very different lines in this PR. The same goes for the line numbers in the Error stack trace of your other screenshot.

Also the second test you've done is exactly what this PR should also solve. Are you sure you tested correctly?

@LiborBatek
Copy link
Member

ouch my bad, I checkout correct PR but to wrong branch...and run the other!

Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All works as expected. Creating render subset in any circumstances (with/without deadline running).
Repair action aslo works on all subsets and renderlayers as expected. Also sets correctly handle start and handle end. So it also resolves PR #4272

Here is scrncap before repair:
image

and after:

image

here is also DB values for check and all is ok...frame ranges are equal and handles set correctly in maya.
image

@antirotor antirotor merged commit 0bc24c1 into ynput:develop Jan 6, 2023
@github-actions github-actions bot added this to the next-patch milestone Jan 6, 2023
@BigRoy BigRoy deleted the fix4272_validateframerange branch March 20, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants