New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maya: Fix validate frame range repair + fix create render with deadline disabled #4279
Conversation
…and `handleEnd` available on instance
… Render with Deadline module disabled)
Did a first run of tests with creating All works when creating So no issues found on Test (1) |
Test 02 - different frame start / end + frame handles setting and The Another issue with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pls see comments, needs change doesnt work as expected.
@LiborBatek I'm pretty sure you were NOT running those tests on the code in this PR but were running it on a different branch. The line numbers in the error of your first screenshot here refer to very different lines in this PR. The same goes for the line numbers in the Error stack trace of your other screenshot. Also the second test you've done is exactly what this PR should also solve. Are you sure you tested correctly? |
ouch my bad, I checkout correct PR but to wrong branch...and run the other! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All works as expected. Creating render
subset in any circumstances (with/without deadline running).
Repair action aslo works on all subsets and renderlayers as expected. Also sets correctly handle start and handle end. So it also resolves PR #4272
Here is scrncap before repair:
and after:
here is also DB values for check and all is ok...frame ranges are equal and handles set correctly in maya.
Brief description
This fixes:
handleStart
andhandleEnd
attribute exists on the instanceTesting notes:
renderingMain
globals.