Deactivate closed Kitsu projects on OP

[friquette]

Changelog Description

Deactivate project on OP when the project is closed on Kitsu.

[iLLiCiTiT]

Expanding this #4619 (comment) . So this would not work?

closed_status_id = None
for status in gazu.project.all_project_status():
    if status["name"].lower() == "closed":
        closed_status_id = status["id"]

project_is_active = project["project_status_id"] != closed_status_id

If not, why we just don't look if the project is is opened projects instead of calculating "closed projects"?

all_kitsu_open_projects_names = {
    project['name'] for project in gazu.project.all_open_projects()
}
project_is_active = project_name in all_kitsu_open_projects_names

EDITED: Could the update state be caused because of cache? So there should be gazu.cache.clear_all() called before sync? Maybe it already happens I'm not familiar with the implementation.

[iLLiCiTiT]

@Tilix4 could you take a look? Thank you :)

[Tilix4]

Two small suggestions, otherwise LGTM

[Tilix4]

LGTM!

[BigRoy]

Haven't tested the code but changes look good to me.

Only optimization I see if that we could potentially query the gazu.project.all_project_status() only once and pass it to sync_project_from_kitsu instead of querying it per project. But I assume it's not a performance issue currently for anyone so I suppose it's fine for everyone. :)

[iLLiCiTiT]

Please update the branch

[Tilix4]

With all this contributions, it gets very clean and straight forward, nice job!
One actual request lest and one suggestion for better understanding.

[iLLiCiTiT]

Please update the branch

Branch still have conflicts to resolve

[BigRoy]

Haven't tested the code, but changes look good to me. Great work!