Fix: Locally copied version of last published workfile is not incremented #4722

kalisp · 2023-03-27T16:14:44Z

Fix 1

When copied, the local workfile version keeps the published version number, when it must be +1 to follow OP's naming convention.

Fix 2

Local workfile version's name is built from anatomy. This avoids to get workfiles with their publish template naming.

Fix 3

In the case a subset has at least two tasks with published workfiles, for example Modeling and Rigging, launching Rigging was getting the first one with the next and trying to find representations, therefore workfileModeling and trying to match the current task_name (Rigging) with the representation["context"]["task"]["name"] of a Modeling representation, which was ending up to a workfile_representation to None, and exiting the process.

Trying to find the task_name in the subset['name'] fixes it.

Fix 4

Fetch input dependencies of workfile.

Replacing #4102 for changes to bring this home.

…nted

* Enhancement: copy last published workfile as reusable methods (WiP) * Added get_host_extensions method, added subset_id and las_version_doc access, added optional arguments to get_last_published_workfile * Plugged in the new methods + minor changes * Added docstrings, last workfile optional argument, and removed unused code * Using new implementation to get local workfile path. Warning: It adds an extra dot to the extension which I need to fix * Refactoring and fixed double dots * Added match subset_id and get representation method, plus clan up * Removed unused vars * Fixed some rebasing errors * delinted unchanged code and renamed get_representation into get_representation_with_task * This time it's really delinted, I hope... * Update openpype/modules/sync_server/sync_server.py reprenation isn't the right spelling (: Co-authored-by: Félix David <felixg.david@gmail.com> * Changes based on reviews * Fixed non imperative docstring and missing space * Fixed another non imperative docstring * Update openpype/modules/sync_server/sync_server.py Fixed typo Co-authored-by: Félix David <felixg.david@gmail.com> Co-authored-by: Hayley GUILLOT <hayleyguillot@outlook.com> Co-authored-by: Félix David <felixg.david@gmail.com>

* Fix: Local workfile overwrite when local version number is higher than published workfile version number (WiP) * Changed regex search, clean up * Readded mistakenly removed newline

Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>

…e_version_up

Tilix4

LGTM, only one suggestion for markdown doc.

website/docs/module_site_sync.md

Logic should be in pre hook

iLLiCiTiT · 2023-04-11T09:05:24Z

The prelaunch hook does not handle cases when there are no profiles in settings, or when filter_profiles does return None -> BTW I think that profiles should be empty to be skipped by default.

Tilix4 · 2023-04-11T10:15:08Z

Found a bug: If you delete all versions of a workfile subset for an asset and try to launch it after, it tries to find the last published workfile (which has been deleted) and hangs forever. It should not try to fetch it and open a new empty file.

openpype/modules/sync_server/launch_hooks/pre_copy_last_published_workfile.py

kalisp · 2023-04-13T10:17:42Z

Fixed issue with no profiles returned.

kalisp · 2023-04-13T10:19:14Z

Found a bug: If you delete all versions of a workfile subset for an asset and try to launch it after, it tries to find the last published workfile (which has been deleted) and hangs forever. It should not try to fetch it and open a new empty file.

How should I replicate that? I tried to open DCC on new empty task, works.
I tried to delete all published workfiles for particular tasks and open again, works.

BigRoy · 2023-04-13T10:31:25Z

I tried to delete all published workfiles for particular tasks and open again, works.

How did you delete it? Did you use the loader action from the standalone loader? (OP tray > Loader) Because maybe @Tilix4 did use that which I believe 'archives' certain publishes instead of actually removing them from the database?

Tilix4 · 2023-04-13T10:36:18Z

I tried to delete all published workfiles for particular tasks and open again, works.

How did you delete it? Did you use the loader action from the standalone loader? (OP tray > Loader) Because maybe @Tilix4 did use that which I believe 'archives' certain publishes instead of actually removing them from the database?

Indeed that's what I did. That was my guess too.

kalisp · 2023-04-13T12:23:01Z

Yeah, I used Delete version action in Loader.

Tilix4 · 2023-04-13T12:43:20Z

Yeah, I used Delete version action in Loader.

The Delete Old Versions one?

kalisp · 2023-04-13T14:30:19Z

Yeah, thats the one. I deleted all versions of "rigging" task for Visitor and then opened Blender without issue.

openpype/modules/sync_server/launch_hooks/pre_copy_last_published_workfile.py

Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>

Tilix4 · 2023-04-20T14:28:08Z

Yeah, thats the one. I deleted all versions of "rigging" task for Visitor and then opened Blender without issue.

I had this issue by publishing several versions on the same subset and deleting them. It failed until I published the same amount again and them went fine.

That being said, don't block the PR for this as it is not a very frequent use case. We could deal with it later.

Tilix4 and others added 26 commits March 15, 2023 09:16

Fix: Locally copied version of last published workfile is not increme…

96641a4

…nted

fix subset first match

ea39437

correct anatomy name

4fc1110

Fix typo and linting

40e3056

keep source filepath for further path conformation

d123fa0

fetch also input dependencies of workfile

ba96507

required changes

a295751

lint

12ec9ee

fix case only one subset

533d5e5

Fix: syntax error

0947b0a

fix single subset case

d962b26

Restore sync server enabled test in hook

b3409a7

Python2 syntax

f03fecc

renaming and missing key case handling

880e0f2

Fix local workfile overwritten on update in some cases (#7)

608da47

* Fix: Local workfile overwrite when local version number is higher than published workfile version number (WiP) * Changed regex search, clean up * Readded mistakenly removed newline

lint

cd15325

remove anticipated functions for cleaner PR

f066139

remove funcs from entities.py

bd7b590

change to get_last_workfile_with_version

b9660be

clean

743288f

Update openpype/modules/sync_server/sync_server.py

dc5a1c9

Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>

removed get_last_published_workfile_path

d4c066a

moved hook to sync server module

1b32015

fix lint

37f618e

Refactor - download only if not present

a2e4573

kalisp requested a review from Tilix4 March 27, 2023 16:14

kalisp self-assigned this Mar 27, 2023

Merge remote-tracking branch 'origin/develop' into fx_auto_dl_workfil…

0f9f5dd

…e_version_up

kalisp marked this pull request as draft March 27, 2023 16:20

kalisp requested review from Tilix4 and iLLiCiTiT April 3, 2023 09:12

Tilix4 approved these changes Apr 4, 2023

View reviewed changes

website/docs/module_site_sync.md Outdated Show resolved Hide resolved

Refactor - simplified download_last_published_workfile

4e51873

Logic should be in pre hook

hound bot reviewed Apr 12, 2023

View reviewed changes

openpype/modules/sync_server/launch_hooks/pre_copy_last_published_workfile.py Show resolved Hide resolved

kalisp added 2 commits April 13, 2023 12:08

Skip if no profile found

902d9b7

Removed unwanted import

80ebbaf

kalisp unassigned Tilix4 Apr 13, 2023

iLLiCiTiT reviewed Apr 17, 2023

View reviewed changes

openpype/modules/sync_server/launch_hooks/pre_copy_last_published_workfile.py Outdated Show resolved Hide resolved

iLLiCiTiT reviewed Apr 17, 2023

View reviewed changes

openpype/modules/sync_server/launch_hooks/pre_copy_last_published_workfile.py Outdated Show resolved Hide resolved

iLLiCiTiT reviewed Apr 17, 2023

View reviewed changes

openpype/modules/sync_server/launch_hooks/pre_copy_last_published_workfile.py Show resolved Hide resolved

iLLiCiTiT reviewed Apr 17, 2023

View reviewed changes

openpype/modules/sync_server/launch_hooks/pre_copy_last_published_workfile.py Show resolved Hide resolved

kalisp and others added 2 commits April 17, 2023 11:01

Use collected project_doc

3041051

Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>

Use cached project_settings

37ee31f

Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>

kalisp requested a review from iLLiCiTiT April 17, 2023 16:23

iLLiCiTiT approved these changes Apr 28, 2023

View reviewed changes

kalisp merged commit fec104d into develop May 2, 2023
2 checks passed

kalisp deleted the fx_auto_dl_workfile_version_up branch May 2, 2023 16:49

ynbot added this to the next-patch milestone May 2, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: Locally copied version of last published workfile is not incremented #4722

Fix: Locally copied version of last published workfile is not incremented #4722

kalisp commented Mar 27, 2023 •

edited

Loading

Tilix4 left a comment

iLLiCiTiT commented Apr 11, 2023

Tilix4 commented Apr 11, 2023

kalisp commented Apr 13, 2023

kalisp commented Apr 13, 2023

BigRoy commented Apr 13, 2023 •

edited

Loading

Tilix4 commented Apr 13, 2023

kalisp commented Apr 13, 2023

Tilix4 commented Apr 13, 2023

kalisp commented Apr 13, 2023

Tilix4 commented Apr 20, 2023

Fix: Locally copied version of last published workfile is not incremented #4722

Fix: Locally copied version of last published workfile is not incremented #4722

Conversation

kalisp commented Mar 27, 2023 • edited Loading

Fix 1

Fix 2

Fix 3

Fix 4

Tilix4 left a comment

Choose a reason for hiding this comment

iLLiCiTiT commented Apr 11, 2023

Tilix4 commented Apr 11, 2023

kalisp commented Apr 13, 2023

kalisp commented Apr 13, 2023

BigRoy commented Apr 13, 2023 • edited Loading

Tilix4 commented Apr 13, 2023

kalisp commented Apr 13, 2023

Tilix4 commented Apr 13, 2023

kalisp commented Apr 13, 2023

Tilix4 commented Apr 20, 2023

kalisp commented Mar 27, 2023 •

edited

Loading

BigRoy commented Apr 13, 2023 •

edited

Loading