-
Notifications
You must be signed in to change notification settings - Fork 129
Fusion - Resolution and frame range validators #4921
Fusion - Resolution and frame range validators #4921
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some notes
openpype/hosts/fusion/plugins/publish/validate_saver_resolution.py
Outdated
Show resolved
Hide resolved
openpype/hosts/fusion/plugins/publish/validate_saver_resolution.py
Outdated
Show resolved
Hide resolved
openpype/hosts/fusion/plugins/publish/validate_saver_resolution.py
Outdated
Show resolved
Hide resolved
This way `extract_render_local.py` will only render the current wanted frames of the comp.
in case if validate frame range is off this is needed, else reviews would expect the full frame range and not only the rendered frames.
A bunch of fixes and updates! But if you disable the validation Fusion will render the set render range. The only "bug" I have found so far is if you generate reviews with burnins the current frame isn't the correct current frame as the first frame is always the the first expected frame in the assets frame range and maybe not where your custom render range started. I don't find any real way to solve this as that part is hardcoded in the create burning plugin from what I understood of the code. |
Move plugin to before `Collect Instance Data` but after `Collect Anatomy Objects` so gathered/modified data gets fed correctly
This plugin simply process the same data as the validator so it's just duplicate code
95% of all the times the artist want to render the whole comp. If they don't want they should enable "Fusion's current frame range" for the current context. Handles are calculated in "collect comp frame range" so the logged data is correct.
Now when I could add a drop-down list to the collector the validator no longer need to also work as the collector!
The validator checks if the comp currently cover the savers expected frame range. |
openpype/hosts/fusion/plugins/publish/collect_expected_frames.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code wise, I'd say it looks good!
@BigRoy what's your take on this? |
With recent changes to how frames are collected for rendering and now being able to set a frame range per instance (or at least tweak where it gets the frame range from) I suspect a lot of this PR is now obsolete or in a big conflict with the behavior. I think the resolution validator is nice. We might need to just create a new PR with only related changes that still apply to current |
Yeah I need to look over the frame-range validator. Does the new change add a frame-range validator? |
As the frame range validator isn't needed any longer I made a new PR that only contains the resolution validator here: #5325 |
Changelog Description
This PR adds two validators. One for each savers resolution and one for the comps frame range.
Additional info
Both are optional as you might want/need to render out different resolutions and frame ranges.
I also made sure that when selecting problematic nodes in the publisher, the node-view now moves to that node.
Testing notes: