Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Nuke: fixed missing files key in representation #4999

Merged
merged 2 commits into from
May 23, 2023
Merged

Nuke: fixed missing files key in representation #4999

merged 2 commits into from
May 23, 2023

Conversation

jakubjezek001
Copy link
Member

Changelog Description

Issue with missing keys once rendering target set to existing frames is fixed. Instance has to be evaluated in validation for missing files.

Testing notes:

  1. Open nuke workfile and create new Render family instance on any selected node.
  2. Do not render any frames and set instance's render target to Existing frames
  3. hit Publish button and notice that Validate Rendered frames is popping up.
  4. This is correct behaviour.

@ynbot ynbot added size/XS Denotes a PR changes 0-99 lines, ignoring general files type: bug Something isn't working host: Nuke labels May 22, 2023
iLLiCiTiT
iLLiCiTiT approved these changes May 22, 2023
View reviewed changes
Copy link
Member

@iLLiCiTiT iLLiCiTiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion othewise LGTM

@jakubjezek001 @iLLiCiTiT
Update openpype/hosts/nuke/plugins/publish/collect_writes.py
341dc16 
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
@jakubjezek001 jakubjezek001 merged commit 95d4b05 into develop May 23, 2023
@ynbot ynbot added this to the next-patch milestone May 23, 2023
@mkolar mkolar deleted the bugfix/nuke-existing-frames-missing branch June 20, 2023 11:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@iLLiCiTiT iLLiCiTiT iLLiCiTiT approved these changes

@barklaya barklaya Awaiting requested review from barklaya

@LiborBatek LiborBatek Awaiting requested review from LiborBatek

Assignees

@iLLiCiTiT iLLiCiTiT

Labels
host: Nuke size/XS Denotes a PR changes 0-99 lines, ignoring general files type: bug Something isn't working
Projects
PR reviewing
Archived in project
Milestone
3.15.8
Development

Successfully merging this pull request may close these issues.
3 participants
@jakubjezek001 @iLLiCiTiT @ynbot