Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Blender: Deadline support #5438

Merged
merged 38 commits into from
Oct 2, 2023
Merged

Conversation

simonebarbieri
Copy link
Member

Changelog Description

Add Deadline support for Blender.

@simonebarbieri simonebarbieri added sponsored Client endorsed or requested host: Blender module: Deadline AWS Deadline related features type: feature Larger, user affecting changes and completely new things labels Aug 10, 2023
@simonebarbieri simonebarbieri self-assigned this Aug 10, 2023
@ynbot
Copy link
Contributor

ynbot commented Aug 10, 2023

Task linked: OP-6372 Blender submitting to Deadline

@ynbot ynbot added the size/S Denotes a PR changes 100-499 lines, ignoring general files label Aug 10, 2023
@simonebarbieri simonebarbieri changed the title Feature: Deadline support for Blender Blender: Deadline support Aug 10, 2023
@simonebarbieri simonebarbieri marked this pull request as ready for review August 23, 2023 15:56
Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have prepared lighting scene with loaded pointcache animation, created renderLayerMain instance and hit Publish

I m getting following errors during Collect Render Layers phase:


Instance: 
sh004_renderlayerMain
Message: 
'bpy_prop_collection[key]: key "sh004_renderlayerMain" not found'
Line: 
76
Traceback: 
Traceback (most recent call last):
  File "D:\REPO\OpenPype\.venv\lib\site-packages\pyblish\plugin.py", line 527, in __explicit_process
    runner(*args)
  File "D:\REPO\OpenPype\openpype\hosts\blender\plugins\publish\collect_render.py", line 76, in process
KeyError: 'bpy_prop_collection[key]: key "sh004_renderlayerMain" not found'

image

Also I have experienced that user has to select camera when trying to create render instance if not anything selected I get following during creation error:
image

This differs from Maya host OP integration so not sure if it should be mandatory. I can imagine that there should be present validator for render camera during publishing process so it wouldnt be neccesary to pre select the camera when creating.

@LiborBatek
Copy link
Member

There is small glitch with Validate Render Output for Deadline that max being shown even this being in blender host...need to be changed
image

Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All working fine and without any glitches, producing desired renders and reviewables with burnins...

image

@LiborBatek LiborBatek self-requested a review September 18, 2023 08:42
@LiborBatek
Copy link
Member

So there actually some issues regarding using other file formats besides EXR...need to be addressed first

Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fully support other file formats besides EXR, like PNGs, Tiff etc.

Now not fully working.

simonebarbieri and others added 2 commits September 18, 2023 10:52
Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>
@LiborBatek LiborBatek self-requested a review September 21, 2023 06:44
Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I have tested to set Blender and its OP Render Setttings to other format than Exr to PNG and created few AOVs as seen on pic
image

...in blender all good and properly setup when creating fresh new Render instance

image

Job is successfuly rendered on DL as seen here:
image

Problem being that DL Publish Job didnt correctly produced review mp4 just rendered frames in publish folder.
image

Also question being wether we should version each AOVs separately....

In my case, Im having these:

Main_beauty_v06
Main_Normal_v01
Main_Depth_v01
etc.

IMHO not very practical to have different version even the rendered frames originating from the same workfile lighting scene. Should be united under same version...

Lastly, we should also have option if Noisy Image being produced when rendering too....not very practical to have it everytime even when not having accompanying AOVs turned on for later possibility to perform denoise. Most of the cases not desired to produce just Noisy Image without those additional passes needed for post denoise.

This being only valid when turned on Denoising Data in Passes tab so it produces these then:
image

I vote for even not output Noisy Image at all if not set in OP Settings for Blender Render Settings.

Right now its not even possible to turn on these in OP:

Denoising Data producing Denoising Normal, Denoising Albedo, Denoising Depth

@LiborBatek
Copy link
Member

Here is the Publish job on DL log:
Job_2023-09-21_08-37-12_650be498530d594b3d552485.txt

@LiborBatek LiborBatek merged commit a86b204 into develop Oct 2, 2023
1 check passed
@ynbot ynbot added this to the next-patch milestone Oct 2, 2023
@BigRoy
Copy link
Collaborator

BigRoy commented Oct 2, 2023

Didn't do a review - but just wanted to say it's a massive achievement this work has been implemented. Great job! 🥳

@LiborBatek
Copy link
Member

@BigRoy I hope this one will serve for good! Let' s see how this one works in prod!

@mkolar mkolar deleted the feature/OP-6372-blender-deadline branch October 4, 2023 20:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
host: Blender module: Deadline AWS Deadline related features size/S Denotes a PR changes 100-499 lines, ignoring general files sponsored Client endorsed or requested type: feature Larger, user affecting changes and completely new things
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

7 participants