Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Houdini: Add self publish button #5621

Merged
merged 22 commits into from
Oct 18, 2023

Conversation

MustafaJafar
Copy link
Contributor

@MustafaJafar MustafaJafar commented Sep 14, 2023

Changelog Description

This PR allows single publishing by adding a publish button to created rop nodes in Houdini

OpenPype Ayon

Admins are much welcomed to enable it from houdini general settings

OpenPype Ayon

Publish Button also includes all input publish instances.
in this screen shot the alembic instance is ignored because the switch is turned off
image

Additional info

This PR was made to prototype Fabia's idea about publishing one instance in houdini, discord discussion

Testing notes:

  1. Create multiple publish instances in houdini
  2. try publishing from the button

@MustafaJafar MustafaJafar marked this pull request as draft September 14, 2023 18:15
@ynbot ynbot added host: Houdini size/XS Denotes a PR changes 0-99 lines, ignoring general files labels Sep 14, 2023
openpype/hosts/houdini/api/lib.py Outdated Show resolved Hide resolved
openpype/hosts/houdini/api/lib.py Outdated Show resolved Hide resolved
openpype/hosts/houdini/api/lib.py Outdated Show resolved Hide resolved
openpype/hosts/houdini/api/lib.py Outdated Show resolved Hide resolved
openpype/hosts/houdini/api/lib.py Outdated Show resolved Hide resolved
openpype/hosts/houdini/api/lib.py Outdated Show resolved Hide resolved
openpype/hosts/houdini/api/plugin.py Outdated Show resolved Hide resolved
@fabiaserra
Copy link
Contributor

as I said on Discord, could we also expose a string parm called "Comment" (or a pop-up dialog after clicking Publish) where they can type the comment corresponding to that publish?

@fabiaserra
Copy link
Contributor

I like it! Thanks for doing this! I will test it soon

@MustafaJafar MustafaJafar marked this pull request as ready for review September 22, 2023 09:09
@moonyuet
Copy link
Member

moonyuet commented Oct 9, 2023

@antirotor I think this PR is ready for review and merge

@MustafaJafar
Copy link
Contributor Author

MustafaJafar commented Oct 10, 2023

@antirotor I think this PR is ready for review and merge

I think we would need @iLLiCiTiT review too because I modified the publisher a little bit.

Quick recap
This PR provides a quick way to specify what nodes to publish in a "Houdini way" where we connect ROPs to each other and click publish button.

It automates the current workflow and it doesn't enable procedural workflows.
Houdini does provide me with the execution order of nodes but I cannot use this information in any way.

Copy link
Member

@antirotor antirotor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested it and the code looks good. This is one step on a path to make OP/AYON workflow in Houdini more native a procedural but even in this form, it is useful. Thanks @MustafaJafar

@iLLiCiTiT
Copy link
Member

Moved the show and publish logic to Publisher window, which reduced public functions of the window. Also removed reset_on_show argument from host tools. The proper implementation of the functionality would be more complicated. Please re-test if still works as before.

Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>
@antirotor
Copy link
Member

First time publish will (probably) publish stuff ok, but then it will reset the UI and the publishing report/state will be lost. Subsequent publishes are ok.

@MustafaJafar
Copy link
Contributor Author

I tested it many times, seems to work fine.

Copy link
Member

@antirotor antirotor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the reset fix, it works!

@antirotor antirotor merged commit b1dbbcd into develop Oct 18, 2023
3 checks passed
@antirotor antirotor deleted the tests/houdini_rops-self-publish-button branch October 18, 2023 14:22
@ynbot ynbot added this to the next-patch milestone Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
host: Houdini size/XS Denotes a PR changes 0-99 lines, ignoring general files
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

8 participants