-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Houdini: Add self publish button #5621
Conversation
as I said on Discord, could we also expose a string parm called "Comment" (or a pop-up dialog after clicking Publish) where they can type the comment corresponding to that publish? |
I like it! Thanks for doing this! I will test it soon |
@antirotor I think this PR is ready for review and merge |
I think we would need @iLLiCiTiT review too because I modified the publisher a little bit. Quick recap It automates the current workflow and it doesn't enable procedural workflows. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested it and the code looks good. This is one step on a path to make OP/AYON workflow in Houdini more native a procedural but even in this form, it is useful. Thanks @MustafaJafar
Moved the show and publish logic to Publisher window, which reduced public functions of the window. Also removed |
Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>
First time publish will (probably) publish stuff ok, but then it will reset the UI and the publishing report/state will be lost. Subsequent publishes are ok. |
I tested it many times, seems to work fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the reset fix, it works!
Changelog Description
This PR allows single publishing by adding a publish button to created rop nodes in Houdini
Admins are much welcomed to enable it from houdini general settings
Publish Button also includes all input publish instances.
![image](https://private-user-images.githubusercontent.com/20871534/270045061-2e7cbd97-4f9a-4baa-9276-08960a98126b.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjA0NDUxMDcsIm5iZiI6MTcyMDQ0NDgwNywicGF0aCI6Ii8yMDg3MTUzNC8yNzAwNDUwNjEtMmU3Y2JkOTctNGY5YS00YmFhLTkyNzYtMDg5NjBhOTgxMjZiLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MDglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzA4VDEzMjAwN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTVkMzA0Nzc1OGM2Mzk4OWE2YTQwNGQ4ZTIyMzMxYTc5Nzk0ZmM4ZDUwODZkYjc2Y2ZkOTBiNjQ0NDQwMjNhZmMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.JaoA1dSCPss6OM1c4Kmwbzorznth5kPXpId_tdRmVkI)
in this screen shot the alembic instance is ignored because the switch is turned off
Additional info
This PR was made to prototype Fabia's idea about publishing one instance in houdini, discord discussion
Testing notes: