Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

Bugfix/houdini: wrong frame calculation with handles #5698

Merged

Conversation

MustafaJafar
Copy link
Contributor

Changelog Description

This PR make collect plugins to consider handleStart and handleEnd when collecting frame range
it affects three parts:

  1. get frame range in collect plugins
  2. expected file in render plugins
  3. submit houdini job deadline plugin

Testing notes:

  1. create a render instance
  2. publish
  3. check render job meta data

image

@ynbot
Copy link
Contributor

ynbot commented Oct 4, 2023

@ynbot ynbot added type: bug Something isn't working host: Houdini module: Deadline AWS Deadline related features size/S Denotes a PR changes 100-499 lines, ignoring general files labels Oct 4, 2023
@MustafaJafar
Copy link
Contributor Author

as @moonyuet said, if OP wants to control the extraction of files as well (caches and rendering) this validation would probably be more annoying than helpful, there's many different cases you want full control of the rop range you are generating and on the cases you'd want the full range you'd just leave the default of $FSTART and $FEND so the pipeline that already updates the scene frame range handles those cases...

I don't meant to control the frame range.
I think the validator is working correctly by the logged message is wrong.

if users didn't turn off and added their custom frame range without considering start and end handles then
frameStart may have a greater value than frameEnd

do you have any suggestion how to explain that in log.error ?

image


Also, There's BigRoy's suggestion:
Adding handleStart and handleEnd attributes on the instances (initialized with 0) then the toggle on the collector will switch between asset handles and instance handles

Copy link
Collaborator

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test it.
Code looks good - only had some cosmetics comments on a docstring.

openpype/hosts/houdini/api/lib.py Outdated Show resolved Hide resolved
openpype/hosts/houdini/api/lib.py Outdated Show resolved Hide resolved
MustafaJafar and others added 3 commits October 23, 2023 23:04
Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>
Copy link
Member

@moonyuet moonyuet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me in the simple testing.
image

@BigRoy
Copy link
Collaborator

BigRoy commented Oct 24, 2023

@antirotor ready to merge?

@mkolar mkolar merged commit 46ee9cf into develop Oct 25, 2023
1 check passed
@mkolar mkolar deleted the bugfix/OP-6806_Houdini-wrong-frame-calculation-with-handles branch October 25, 2023 22:25
@mkolar
Copy link
Member

mkolar commented Oct 25, 2023

All good. thanks.

@ynbot ynbot added this to the next-patch milestone Oct 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
host: Houdini module: Deadline AWS Deadline related features size/S Denotes a PR changes 100-499 lines, ignoring general files type: bug Something isn't working
Projects
Archived in project
9 participants