-
Notifications
You must be signed in to change notification settings - Fork 128
Bugfix/houdini: wrong frame calculation with handles #5698
Bugfix/houdini: wrong frame calculation with handles #5698
Conversation
openpype/hosts/houdini/plugins/publish/collect_rop_frame_range.py
Outdated
Show resolved
Hide resolved
openpype/hosts/houdini/plugins/publish/collect_rop_frame_range.py
Outdated
Show resolved
Hide resolved
openpype/hosts/houdini/plugins/publish/collect_rop_frame_range.py
Outdated
Show resolved
Hide resolved
I don't meant to control the frame range. if users didn't turn off and added their custom frame range without considering start and end handles then do you have any suggestion how to explain that in log.error ? Also, There's BigRoy's suggestion: |
openpype/hosts/houdini/plugins/publish/collect_rop_frame_range.py
Outdated
Show resolved
Hide resolved
…ation-with-handles
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't test it.
Code looks good - only had some cosmetics comments on a docstring.
Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…ation-with-handles
@antirotor ready to merge? |
All good. thanks. |
Changelog Description
This PR make collect plugins to consider
handleStart
andhandleEnd
when collecting frame rangeit affects three parts:
Testing notes: