This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Photoshop: remove trailing underscore in subset name #5647
Merged
+46
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If {layer} placeholder is at the end of subset name template and not used (for example in auto_image where separating it by layer doesn't make any sense) trailing '_' was kept.
This updates cleaning logic and extracts it as it might be similar in regular `image` instance.
|
Task linked: OP-6874 Auto_image template name |
ynbot
added
size/XS
64qam
approved these changes
Sep 25, 2023
santi-svirsky
pushed a commit
to santi-svirsky/OpenPype
that referenced
this pull request
Oct 8, 2023
If {layer} placeholder is at the end of subset name template and not used (for example in auto_image where separating it by layer doesn't make any sense) trailing '_' was kept.
This updates cleaning logic and extracts it as it might be similar in regular `image` instance.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
If {layer} placeholder is at the end of subset name template and not used (for example in
auto_imagewhere separating it by layer doesn't make any sense) trailing '_' was kept. This updates cleaning logic and extracts it as it might be similar in regularimageinstance.Testing notes:
1.Configure
project_settings/global/tools/creator/subset_name_profilesset something like{family}_{Task}_{Variant}_{layer}2. try to publish from fresh new workfile