Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

AYON: Tools enhancements #5753

Merged
merged 13 commits into from
Oct 13, 2023
Merged

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Oct 12, 2023

Changelog Description

Few enhancements and tweaks of AYON related tools.

Additional info

  • Fixed typo set_name_filer to set_name_filter.
  • Renamed get_current_project_name to get_selected_project_name in ProjectsCombobox.
  • Hierarchy model adds more information to FolderItem (path and folder type).
  • Moved universal TreeView to tool utils from workfiles tool, and use it in FoldersWidget.
  • UNDERLINE_COLORS_ROLE has bigger offset to avoid clashes with FoldersWidget roles.
  • Projects/Folders/Tasks widgets have more public methods and signals.

Branch of this PR will be used as base for few of my future PRs.

Testing notes:

All changes should not affect, any logic of tools. All tools loader, workfiles, launcher should work as expected.

@ynbot ynbot added size/S Denotes a PR changes 100-499 lines, ignoring general files type: enhancement Enhancements to existing functionality labels Oct 12, 2023
@LiborBatek
Copy link
Member

LiborBatek commented Oct 12, 2023

First issue being in the Launcher that when triggering Explore Here on top folder it says Folder does not exists even tho it does...
image
however it works on others like
shots
shots_b3d
in my particular case and also on assets and their corresponding task

@LiborBatek
Copy link
Member

LiborBatek commented Oct 12, 2023

The Focus to context btn or how to call this function btn does not work in all cases....not keeping the proper task when hit and switch to the other task type in the asset instead, it works some times but some times not. Leading user to different task type which could lead to confusion and possible mistake when triggering Save As later on.
Focus_Btn_Issue

And in Loader this Focus Context btn doesnt do anything at all...is that correct??
image

@iLLiCiTiT
Copy link
Member Author

iLLiCiTiT commented Oct 12, 2023

The Focus to context btn or how to call this function btn does not work in all cases....

Good point, but that's not caused by this PR, and I don't plan to fix it in this PR. Fixed for loader. Workfiles tool needs more attention in different PR.

First issue being in the Launcher that when triggering Explore Here on top folder it says Folder does not exists even tho it does...

Completelly unrelated to this PR. Already has created issue and task.

Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All seems fine.

@iLLiCiTiT iLLiCiTiT merged commit 9c53837 into develop Oct 13, 2023
3 checks passed
@iLLiCiTiT iLLiCiTiT deleted the enhancement/ayon-tools-enhancements branch October 13, 2023 08:40
@ynbot ynbot added this to the next-patch milestone Oct 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/S Denotes a PR changes 100-499 lines, ignoring general files type: enhancement Enhancements to existing functionality
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants