Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Fusion: added missing OPENPYPE_VERSION #5776

Merged

Conversation

kalisp
Copy link
Member

@kalisp kalisp commented Oct 17, 2023

Changelog Description

Fusion submission to Deadline was missing OPENPYPE_VERSION env var when submitting from build (not source code directly). This missing env var might break rendering on DL if path to OP executable (openpype_console.exe) is not set explicitly and might cause an issue when different versions of OP are deployed.

This PR adds this environment variable.

Testing notes:

  1. build OP
  2. start publish from build and Fusion
  3. check that render job Environments contain OPENPYPE_VERSION
  4. remove explicit path to openpype_console.exe (and keep only dir there?)
  5. try to republish again

@ynbot
Copy link
Contributor

ynbot commented Oct 17, 2023

6 similar comments
@ynbot
Copy link
Contributor

ynbot commented Oct 17, 2023

@ynbot
Copy link
Contributor

ynbot commented Oct 17, 2023

@ynbot
Copy link
Contributor

ynbot commented Oct 17, 2023

@ynbot
Copy link
Contributor

ynbot commented Oct 17, 2023

@ynbot
Copy link
Contributor

ynbot commented Oct 17, 2023

@ynbot
Copy link
Contributor

ynbot commented Oct 17, 2023

@ynbot ynbot added size/XS Denotes a PR changes 0-99 lines, ignoring general files type: bug Something isn't working host: Fusion module: Deadline AWS Deadline related features labels Oct 17, 2023
Copy link
Collaborator

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test but code make sense and matches other hosts.

@iLLiCiTiT iLLiCiTiT merged commit d22375f into develop Oct 17, 2023
13 checks passed
@iLLiCiTiT iLLiCiTiT deleted the bugfix/OP-7134_OPENPYPE_VERSIONmissing-in-Fusion-submission branch October 17, 2023 08:56
@ynbot ynbot added this to the next-patch milestone Oct 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
host: Fusion module: Deadline AWS Deadline related features size/XS Denotes a PR changes 0-99 lines, ignoring general files type: bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants