Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maya: ingest expected testing files #5785

Conversation

tokejepsen
Copy link
Member

Changelog Description

This PR ingests the expected output files from testing, from the GDrive location. There are Maya binary files, but that will change once we ingest the input workfile later.

Split from #5644

Testing notes:

.\openpype_console.bat runtests C:\Users\tokejepsen\OpenPype\tests\integration\hosts\maya\test_publish_in_maya.py --mongo_url "mongodb://localhost:2707/"

@tokejepsen tokejepsen added the sponsored Client endorsed or requested label Oct 18, 2023
@ynbot ynbot added type: enhancement Enhancements to existing functionality size/XL Denotes a PR changes 1500-2499 lines, ignoring general files host: Maya labels Oct 18, 2023
@tokejepsen tokejepsen changed the title Maya: ingest Maya expected files Maya: ingest expected testing files Oct 18, 2023
@kalisp
Copy link
Member

kalisp commented Oct 19, 2023

How does this work with multiple test cases? Maya has 2 right now, so I would expect separation by test name.
I don't particulary added files into /maya/expected/files/test_project/test_asset/ path, seems unnecessary and not matching all other DCC.

@kalisp kalisp assigned tokejepsen and unassigned kalisp Oct 27, 2023
@tokejepsen
Copy link
Member Author

@kalisp

How does this work with multiple test cases?

As expected_dir_base can be defined in each test, we can have a folder for each test case with expected data if they are not shared between tests.

Maya has 2 right now, so I would expect separation by test name.

We can separate the expected testing files by the test name. Do you have a preference of folder structure?

I don't particulary added files into /maya/expected/files/test_project/test_asset/ path, seems unnecessary and not matching all other DCC.

The intent is to ingest the database as well eventually, so wanted to differentiate between expected files and database. But we can start with this PR and skip on the files subfolder for now?

@tokejepsen
Copy link
Member Author

Superseeded by #5840

@tokejepsen tokejepsen closed this Nov 9, 2023
@tokejepsen tokejepsen deleted the enhancement/testing_maya_expected_files branch November 9, 2023 16:03
@ynbot ynbot added this to the next-patch milestone Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
host: Maya size/XL Denotes a PR changes 1500-2499 lines, ignoring general files sponsored Client endorsed or requested type: enhancement Enhancements to existing functionality
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants