This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 129
Testing: Ingest expected files and input workfile #5840
Merged
kalisp
merged 13 commits into
ynput:develop
from
tokejepsen:enhancement/testing_maya_input_workfile
Nov 9, 2023
Merged
Testing: Ingest expected files and input workfile #5840
kalisp
merged 13 commits into
ynput:develop
from
tokejepsen:enhancement/testing_maya_input_workfile
Nov 9, 2023
+9,347
−97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ynbot
added
type: enhancement
Enhancements to existing functionality
host: Maya
size/XL
Denotes a PR changes 1500-2499 lines, ignoring general files
labels
Oct 31, 2023
Implemented LocalFileHandler. Test name added to structure to separate files for each test. Removed superfluous `files` to keep other Maya test working
@kalisp nice solution! I've fixed some issues and added a suggestion to skip directories when checking the folder structure, otherwise I get this error when testing Maya:
We could maybe look at preventing Maya from creating the empty folder in the first place, but I dont think that is worth the effort. And is there any point in testing for empty folders? |
I think there is no need to test empty folders, just wondering why it haven't happened for me. (Oh, I know, thats probably git, it will not create empty folders but I copied them.) |
tokejepsen
changed the title
Testing: Ingest Maya Input Workfile
Testing: Ingest expected files and input workfile
Nov 9, 2023
BigRoy
reviewed
Nov 9, 2023
BigRoy
reviewed
Nov 9, 2023
BigRoy
reviewed
Nov 9, 2023
BigRoy
reviewed
Nov 9, 2023
BigRoy
reviewed
Nov 9, 2023
tests/integration/hosts/maya/test_publish_in_maya/input/dumps/openpype_tests/logs.bson
Outdated
Show resolved
Hide resolved
BigRoy
reviewed
Nov 9, 2023
tests/integration/hosts/maya/test_publish_in_maya/input/dumps/avalon_tests/test_project.bson
Outdated
Show resolved
Hide resolved
BigRoy
reviewed
Nov 9, 2023
...ion/hosts/maya/test_publish_in_maya/input/workfile/test_project_test_asset_test_task_v001.ma
Show resolved
Hide resolved
Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>
…hub.com/tokejepsen/pype into enhancement/testing_maya_input_workfile
tests/integration/hosts/maya/test_deadline_publish_in_maya/input/startup/userSetup.py
Show resolved
Hide resolved
tests/integration/hosts/maya/test_deadline_publish_in_maya/input/startup/userSetup.py
Show resolved
Hide resolved
tests/integration/hosts/maya/test_deadline_publish_in_maya/input/startup/userSetup.py
Show resolved
Hide resolved
kalisp
approved these changes
Nov 9, 2023
Does this still depend on #5785 ? I think that one should be closed and only this PR used. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
host: Maya
module: Deadline
AWS Deadline related features
size/XL
Denotes a PR changes 1500-2499 lines, ignoring general files
sponsored
Client endorsed or requested
type: enhancement
Enhancements to existing functionality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
This ingests the Maya workfile from the Drive storage. Have changed the format to MayaAscii so its easier to see what changes are happening in a PR. This meant changing the expected files and database entries as well.
Testing notes:
Split from #5644