Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blender: Better name of 'asset_name' function #5927

Merged
merged 2 commits into from
Nov 16, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions openpype/hosts/blender/api/plugin.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
VALID_EXTENSIONS = [".blend", ".json", ".abc", ".fbx"]


def asset_name(
def prepare_scene_name(
asset: str, subset: str, namespace: Optional[str] = None
) -> str:
"""Return a consistent name for an asset."""
Expand Down Expand Up @@ -225,7 +225,7 @@ def create(
bpy.context.scene.collection.children.link(instances)

# Create asset group
name = asset_name(instance_data["asset"], subset_name)
name = prepare_scene_name(instance_data["asset"], subset_name)
if self.create_as_asset_group:
# Create instance as empty
instance_node = bpy.data.objects.new(name=name, object_data=None)
Expand Down Expand Up @@ -298,7 +298,9 @@ def update_instances(self, update_list):
"subset" in changes.changed_keys
or "asset" in changes.changed_keys
):
name = asset_name(asset=data["asset"], subset=data["subset"])
name = prepare_scene_name(
asset=data["asset"], subset=data["subset"]
)
node.name = name

imprint(node, data)
Expand Down Expand Up @@ -454,7 +456,7 @@ def _load(self,
asset, subset
)
namespace = namespace or f"{asset}_{unique_number}"
name = name or asset_name(
name = name or prepare_scene_name(
asset, subset, unique_number
)

Expand Down Expand Up @@ -483,7 +485,9 @@ def _load(self,

# asset = context["asset"]["name"]
# subset = context["subset"]["name"]
# instance_name = asset_name(asset, subset, unique_number) + '_CON'
# instance_name = prepare_scene_name(
# asset, subset, unique_number
# ) + '_CON'

# return self._get_instance_collection(instance_name, nodes)

Expand Down
2 changes: 1 addition & 1 deletion openpype/hosts/blender/plugins/create/create_action.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ def create(
)

# Get instance name
name = plugin.asset_name(instance_data["asset"], subset_name)
name = plugin.prepare_scene_name(instance_data["asset"], subset_name)

if pre_create_data.get("use_selection"):
for obj in lib.get_selection():
Expand Down
2 changes: 1 addition & 1 deletion openpype/hosts/blender/plugins/load/import_workfile.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ def append_workfile(context, fname, do_import):
asset = context['asset']['name']
subset = context['subset']['name']

group_name = plugin.asset_name(asset, subset)
group_name = plugin.prepare_scene_name(asset, subset)

# We need to preserve the original names of the scenes, otherwise,
# if there are duplicate names in the current workfile, the imported
Expand Down
4 changes: 2 additions & 2 deletions openpype/hosts/blender/plugins/load/load_abc.py
Original file line number Diff line number Diff line change
Expand Up @@ -137,9 +137,9 @@ def process_asset(
asset = context["asset"]["name"]
subset = context["subset"]["name"]

asset_name = plugin.asset_name(asset, subset)
asset_name = plugin.prepare_scene_name(asset, subset)
unique_number = plugin.get_unique_number(asset, subset)
group_name = plugin.asset_name(asset, subset, unique_number)
group_name = plugin.prepare_scene_name(asset, subset, unique_number)
namespace = namespace or f"{asset}_{unique_number}"

containers = bpy.data.collections.get(AVALON_CONTAINERS)
Expand Down
10 changes: 5 additions & 5 deletions openpype/hosts/blender/plugins/load/load_action.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

import bpy
from openpype.pipeline import get_representation_path
import openpype.hosts.blender.api.plugin
from openpype.hosts.blender.api import plugin
from openpype.hosts.blender.api.pipeline import (
containerise_existing,
AVALON_PROPERTY,
Expand All @@ -16,7 +16,7 @@
logger = logging.getLogger("openpype").getChild("blender").getChild("load_action")


class BlendActionLoader(openpype.hosts.blender.api.plugin.AssetLoader):
class BlendActionLoader(plugin.AssetLoader):
"""Load action from a .blend file.

Warning:
Expand Down Expand Up @@ -46,8 +46,8 @@ def process_asset(
libpath = self.filepath_from_context(context)
asset = context["asset"]["name"]
subset = context["subset"]["name"]
lib_container = openpype.hosts.blender.api.plugin.asset_name(asset, subset)
container_name = openpype.hosts.blender.api.plugin.asset_name(
lib_container = plugin.prepare_scene_name(asset, subset)
container_name = plugin.prepare_scene_name(
asset, subset, namespace
)

Expand Down Expand Up @@ -152,7 +152,7 @@ def update(self, container: Dict, representation: Dict):
assert libpath.is_file(), (
f"The file doesn't exist: {libpath}"
)
assert extension in openpype.hosts.blender.api.plugin.VALID_EXTENSIONS, (
assert extension in plugin.VALID_EXTENSIONS, (
f"Unsupported file: {libpath}"
)

Expand Down
4 changes: 2 additions & 2 deletions openpype/hosts/blender/plugins/load/load_audio.py
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,9 @@ def process_asset(
asset = context["asset"]["name"]
subset = context["subset"]["name"]

asset_name = plugin.asset_name(asset, subset)
asset_name = plugin.prepare_scene_name(asset, subset)
unique_number = plugin.get_unique_number(asset, subset)
group_name = plugin.asset_name(asset, subset, unique_number)
group_name = plugin.prepare_scene_name(asset, subset, unique_number)
namespace = namespace or f"{asset}_{unique_number}"

avalon_container = bpy.data.collections.get(AVALON_CONTAINERS)
Expand Down
4 changes: 2 additions & 2 deletions openpype/hosts/blender/plugins/load/load_blend.py
Original file line number Diff line number Diff line change
Expand Up @@ -133,9 +133,9 @@ def process_asset(

representation = str(context["representation"]["_id"])

asset_name = plugin.asset_name(asset, subset)
asset_name = plugin.prepare_scene_name(asset, subset)
unique_number = plugin.get_unique_number(asset, subset)
group_name = plugin.asset_name(asset, subset, unique_number)
group_name = plugin.prepare_scene_name(asset, subset, unique_number)
namespace = namespace or f"{asset}_{unique_number}"

avalon_container = bpy.data.collections.get(AVALON_CONTAINERS)
Expand Down
4 changes: 2 additions & 2 deletions openpype/hosts/blender/plugins/load/load_blendscene.py
Original file line number Diff line number Diff line change
Expand Up @@ -85,9 +85,9 @@ def process_asset(
except ValueError:
family = "model"

asset_name = plugin.asset_name(asset, subset)
asset_name = plugin.prepare_scene_name(asset, subset)
unique_number = plugin.get_unique_number(asset, subset)
group_name = plugin.asset_name(asset, subset, unique_number)
group_name = plugin.prepare_scene_name(asset, subset, unique_number)
namespace = namespace or f"{asset}_{unique_number}"

avalon_container = bpy.data.collections.get(AVALON_CONTAINERS)
Expand Down
4 changes: 2 additions & 2 deletions openpype/hosts/blender/plugins/load/load_camera_abc.py
Original file line number Diff line number Diff line change
Expand Up @@ -87,9 +87,9 @@ def process_asset(
asset = context["asset"]["name"]
subset = context["subset"]["name"]

asset_name = plugin.asset_name(asset, subset)
asset_name = plugin.prepare_scene_name(asset, subset)
unique_number = plugin.get_unique_number(asset, subset)
group_name = plugin.asset_name(asset, subset, unique_number)
group_name = plugin.prepare_scene_name(asset, subset, unique_number)
namespace = namespace or f"{asset}_{unique_number}"

avalon_container = bpy.data.collections.get(AVALON_CONTAINERS)
Expand Down
4 changes: 2 additions & 2 deletions openpype/hosts/blender/plugins/load/load_camera_fbx.py
Original file line number Diff line number Diff line change
Expand Up @@ -90,9 +90,9 @@ def process_asset(
asset = context["asset"]["name"]
subset = context["subset"]["name"]

asset_name = plugin.asset_name(asset, subset)
asset_name = plugin.prepare_scene_name(asset, subset)
unique_number = plugin.get_unique_number(asset, subset)
group_name = plugin.asset_name(asset, subset, unique_number)
group_name = plugin.prepare_scene_name(asset, subset, unique_number)
namespace = namespace or f"{asset}_{unique_number}"

avalon_container = bpy.data.collections.get(AVALON_CONTAINERS)
Expand Down
4 changes: 2 additions & 2 deletions openpype/hosts/blender/plugins/load/load_fbx.py
Original file line number Diff line number Diff line change
Expand Up @@ -134,9 +134,9 @@ def process_asset(
asset = context["asset"]["name"]
subset = context["subset"]["name"]

asset_name = plugin.asset_name(asset, subset)
asset_name = plugin.prepare_scene_name(asset, subset)
unique_number = plugin.get_unique_number(asset, subset)
group_name = plugin.asset_name(asset, subset, unique_number)
group_name = plugin.prepare_scene_name(asset, subset, unique_number)
namespace = namespace or f"{asset}_{unique_number}"

avalon_container = bpy.data.collections.get(AVALON_CONTAINERS)
Expand Down
4 changes: 2 additions & 2 deletions openpype/hosts/blender/plugins/load/load_layout_json.py
Original file line number Diff line number Diff line change
Expand Up @@ -149,9 +149,9 @@ def process_asset(self,
asset = context["asset"]["name"]
subset = context["subset"]["name"]

asset_name = plugin.asset_name(asset, subset)
asset_name = plugin.prepare_scene_name(asset, subset)
unique_number = plugin.get_unique_number(asset, subset)
group_name = plugin.asset_name(asset, subset, unique_number)
group_name = plugin.prepare_scene_name(asset, subset, unique_number)
namespace = namespace or f"{asset}_{unique_number}"

avalon_container = bpy.data.collections.get(AVALON_CONTAINERS)
Expand Down
4 changes: 2 additions & 2 deletions openpype/hosts/blender/plugins/load/load_look.py
Original file line number Diff line number Diff line change
Expand Up @@ -96,14 +96,14 @@ def process_asset(
asset = context["asset"]["name"]
subset = context["subset"]["name"]

lib_container = plugin.asset_name(
lib_container = plugin.prepare_scene_name(
asset, subset
)
unique_number = plugin.get_unique_number(
asset, subset
)
namespace = namespace or f"{asset}_{unique_number}"
container_name = plugin.asset_name(
container_name = plugin.prepare_scene_name(
asset, subset, unique_number
)

Expand Down
Loading