Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Blender: Better name of 'asset_name' function #5927

Merged
merged 2 commits into from
Nov 16, 2023

Conversation

iLLiCiTiT
Copy link
Member

Changelog Description

Renamed function asset_name to prepare_scene_name.

Additional info

The name asset_name is not very good decision for a function name. It does not tell what the function does and the name canot be used as variable where the function is used. I've hit an issue when I wanted to use variable asset_name.

Testing notes:

  1. All loaders and creators should work as before this PR.

@ynbot ynbot added type: enhancement Enhancements to existing functionality size/XS Denotes a PR changes 0-99 lines, ignoring general files host: Blender labels Nov 16, 2023
Copy link
Collaborator

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - I really hated that one too, good to see it fixed.

Didn't test but the refactor looks good to me.

Copy link
Contributor

@simonebarbieri simonebarbieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works!

@simonebarbieri simonebarbieri merged commit 8963116 into develop Nov 16, 2023
5 checks passed
@ynbot ynbot added this to the next-patch milestone Nov 16, 2023
@iLLiCiTiT iLLiCiTiT deleted the enhancement/blender-function-name-enhancement branch November 16, 2023 10:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
host: Blender size/XS Denotes a PR changes 0-99 lines, ignoring general files type: enhancement Enhancements to existing functionality
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants