Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blender: Better name of 'asset_name' function #5927

Merged
merged 2 commits into from
Nov 16, 2023
Merged

Blender: Better name of 'asset_name' function #5927

merged 2 commits into from
Nov 16, 2023

Conversation

iLLiCiTiT
Copy link
Member

Changelog Description

Renamed function asset_name to prepare_scene_name.

Additional info

The name asset_name is not very good decision for a function name. It does not tell what the function does and the name canot be used as variable where the function is used. I've hit an issue when I wanted to use variable asset_name.

Testing notes:

  1. All loaders and creators should work as before this PR.

@ynbot ynbot added type: enhancement Enhancements to existing functionality size/XS Denotes a PR changes 0-99 lines, ignoring general files host: Blender labels Nov 16, 2023
BigRoy
BigRoy approved these changes Nov 16, 2023
View reviewed changes
Copy link
Collaborator

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - I really hated that one too, good to see it fixed.

Didn't test but the refactor looks good to me.

simonebarbieri
simonebarbieri approved these changes Nov 16, 2023
View reviewed changes
Copy link
Member

@simonebarbieri simonebarbieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works!

@simonebarbieri simonebarbieri merged commit 8963116 into develop Nov 16, 2023
5 checks passed
@ynbot ynbot added this to the next-patch milestone Nov 16, 2023
@iLLiCiTiT iLLiCiTiT deleted the enhancement/blender-function-name-enhancement branch November 16, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonebarbieri simonebarbieri simonebarbieri approved these changes

@BigRoy BigRoy BigRoy approved these changes

Assignees

@simonebarbieri simonebarbieri

Labels
host: Blender size/XS Denotes a PR changes 0-99 lines, ignoring general files type: enhancement Enhancements to existing functionality
Projects
PR reviewing
Archived in project
Milestone
3.17.6
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@iLLiCiTiT @simonebarbieri @BigRoy @ynbot