-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
General: Use colorspace data when creating thumbnail #5938
General: Use colorspace data when creating thumbnail #5938
Conversation
…_thumbnail-color-managed
Task linked: OP-6659 Maya: thumbnail color space |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't tested it but code looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these 2 frames are closer enough I guess....but still the color rendering seems fine @BigRoy Good catch! |
Haha, actually - I meant that there's some sort of square pattern in the image, e.g. visible here: It's only on the left view. Anyway, likely unrelated to this PR. |
Thank you all people and mainly @tokejepsen ! |
Changelog Description
Thumbnails with applied colormanagement.
Additional info
Originally developed by @tokejepsen at #5256
TODO:
Testing notes:
Explicit Thumbnai workflow > development stages
original PR
This PR is just a placeholder and will be broken into smaller chunks:
need-thumbnail
tag and cross plugin flowpublish_on_farm
tags