Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General: Use colorspace data when creating thumbnail #5938

Merged
merged 20 commits into from
Nov 29, 2023

Conversation

jakubjezek001
Copy link
Member

@jakubjezek001 jakubjezek001 commented Nov 20, 2023

Changelog Description

Thumbnails with applied colormanagement.

Additional info

Originally developed by @tokejepsen at #5256

  • added settings for default target values at oiio section default

TODO:

  • ayon server settings

Testing notes:

  1. Create a render or review.
  2. Publish and verify thumbnail is correct color.
  • Maya (farm render / review local)
  • Houdini (farm only)
  • Fusion
  • Blender (farm only)
  • 3dsmax (farm only)
  • Resolve
  • TrayPublisher
  • Substancepainter
  • Nuke (local, farm)

Explicit Thumbnai workflow > development stages

original PR
This PR is just a placeholder and will be broken into smaller chunks:

@ynbot
Copy link
Contributor

ynbot commented Nov 20, 2023

Task linked: OP-6659 Maya: thumbnail color space

@ynbot ynbot added size/XS Denotes a PR changes 0-99 lines, ignoring general files type: enhancement Enhancements to existing functionality labels Nov 20, 2023
Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it works when speaking of thumbnail and maya publishing.

Both rendered seq and thumbnail matches colorwise (being both in ACEScg/ sRGB view transform).

The thumbnail matches the maya rendering space, so all good!
PR_thumb_tests

@moonyuet
Copy link
Member

Simple test in 3dsMax.
It appears to have some colorspace differences.(but it could be my lighting issue)
image
I also tested in Houdini
But it seems that it doesn't have any thumbnail created.(Not related to this PR)
I would also test Review in Houdini Later
image

Copy link
Member

@antirotor antirotor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested it but code looks good.

openpype/plugins/publish/extract_thumbnail.py Outdated Show resolved Hide resolved
Copy link
Member

@moonyuet moonyuet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works nicely with Max Review Family.
image
I have encountered some errors with Houdini rendering (but it is not related to this PR), I will try to render in Houdini again to check the colorspace.

@LiborBatek
Copy link
Member

LiborBatek commented Nov 29, 2023

I have performed also test in blender and all working fine here too...

Thumbnail on the left matches exactly the review mov on the right! Nevermind the red light on the right side, its from different time of animation with red blinking light:)

image

@BigRoy
Copy link
Collaborator

BigRoy commented Nov 29, 2023

I have performed also test in blender and all working fine here too...

Thumbnail on the left matches exactly the review mov on the right!
image

Is the left one your viewport? What's up with the square cubes in the image? :) It has all these square blocks.

@LiborBatek
Copy link
Member

I have performed also test in blender and all working fine here too...
Thumbnail on the left matches exactly the review mov on the right!
image

Is the left one your viewport? What's up with the square cubes in the image? :) It has all these square blocks.

Haha, yeah srry just different frame of animation which has blinking red lights! My bad, didnt realize that thumbnail being different time frame :D

@LiborBatek
Copy link
Member

these 2 frames are closer enough I guess....but still the color rendering seems fine
image

@BigRoy Good catch!

@BigRoy
Copy link
Collaborator

BigRoy commented Nov 29, 2023

these 2 frames are closer enough I guess....but still the color rendering seems fine image

@BigRoy Good catch!

Haha, actually - I meant that there's some sort of square pattern in the image, e.g. visible here:
image

It's only on the left view. Anyway, likely unrelated to this PR.

@moonyuet
Copy link
Member

the color also matches in Houdini
image

@jakubjezek001 jakubjezek001 merged commit ced3e1e into develop Nov 29, 2023
3 checks passed
@jakubjezek001 jakubjezek001 deleted the enhancement/OP-6659_thumbnail-color-managed branch November 29, 2023 20:26
@ynbot ynbot added this to the next-patch milestone Nov 29, 2023
@jakubjezek001
Copy link
Member Author

Thank you all people and mainly @tokejepsen !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR changes 0-99 lines, ignoring general files type: enhancement Enhancements to existing functionality
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

8 participants