Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ftrack: rewriting component creation to support multiple thumbnails #5939

Merged

Conversation

jakubjezek001
Copy link
Member

@jakubjezek001 jakubjezek001 commented Nov 21, 2023

Changelog Description

The creation of Ftrack components needs to allow for multiple thumbnails. This is important in situations where there could be several reviewable streams, like in the case of a nuke intermediate files preset. Customers have asked for unique thumbnails for each data stream.

For instance, one stream might contain a baked LUT file along with Display and View. Another stream might only include the baked Display and View. These variations can change the overall look. Thus, we found it necessary to depict these differences via thumbnails.

Additional info

Testing notes:

  1. Thumbnails in all hosts should work as before

Explicit Thumbnai workflow > development stages

original PR
This PR is just a placeholder and will be broken into smaller chunks:

@ynbot
Copy link
Contributor

ynbot commented Nov 21, 2023

Task linked: OP-6659 Maya: thumbnail color space

@ynbot ynbot added type: enhancement Enhancements to existing functionality size/S Denotes a PR changes 100-499 lines, ignoring general files module: Ftrack labels Nov 21, 2023
jakubjezek001 added a commit that referenced this pull request Nov 21, 2023
Copy link
Member

@kalisp kalisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't break any existing integration test where thumbnails are being used.

@mkolar
Copy link
Member

mkolar commented Nov 24, 2023

Sounds like we can merge.

@mkolar mkolar merged commit a063988 into develop Nov 24, 2023
12 of 13 checks passed
@mkolar mkolar deleted the enhancement/OP-6659_ftrack-component-multiple-thumbnails branch November 24, 2023 23:21
@ynbot ynbot added this to the next-patch milestone Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: Ftrack size/S Denotes a PR changes 100-499 lines, ignoring general files type: enhancement Enhancements to existing functionality
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

7 participants