Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use product name templates for render products on local Houdini render #543

Conversation

MustafaJafar
Copy link
Contributor

Changelog Description

This PR extends #447 and make it work with local Houdini render

Testing notes:

  1. Update these settings on ayon server: you can take reference from my screenshots below.
  • ayon+settings://core/tools/creator/product_name_profiles
  • ayon+anatomy://{my-project}/templates/publish/1 render template.
  1. Launch Houdini
  2. Publish Render locally. Here's what to expect:
  • you should find the names of the created runtime instances follow your the template profile
  • you should find the location of the published render follow your render template (we add support for two more keys renderlayer and aov)

Additional Info

Here are some snippets of my settings.
Render template:
image
product_name_profiles:
image

@ynbot ynbot added size/XS type: enhancement Improvement of existing functionality or minor addition labels May 22, 2024
@MustafaJafar
Copy link
Contributor Author

MustafaJafar commented May 22, 2024

Additional Info 2

I'd like to point our to this todo because I don't know the favored way to implement it.
In essence:
This logic

# TODO: Match the value of product_group with the value of
# group_name in farm pyblish functions.
product_group = get_product_name(
context.data["projectName"],
context.data["taskEntity"]["name"],
context.data["taskEntity"]["taskType"],
context.data["hostName"],
product_type,
instance.data["productName"]
)

should match this logic

# Group name isn't based on a product name template as it is
# difficult to differentiate in the custom defined template
# what part is the least common denominator.
if not src_product_name.startswith(skeleton["productType"]):
group_name = '{}{}{}{}{}'.format(
skeleton["productType"],
task_name[0].upper(), task_name[1:],
src_product_name[0].upper(), src_product_name[1:])
else:
group_name = src_product_name


In this PR in its current stat, I think that my product_group is ignored for some reason.
In this screenshot. my published product is not grouped.
image

Copy link
Member

@antirotor antirotor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine, let's merge it and continue

@MustafaJafar MustafaJafar merged commit 871f6a7 into enhancement/render-product-names-templated Jun 13, 2024
5 checks passed
@MustafaJafar MustafaJafar deleted the enhancement/render-product-names-templated-local-houdini-render branch June 13, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
host: Houdini size/XS type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants