-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publisher: filter creators based on task #560
Merged
kalisp
merged 41 commits into
develop
from
enhancement/AY-5539_define-creators-per-task
Jun 10, 2024
Merged
Publisher: filter creators based on task #560
kalisp
merged 41 commits into
develop
from
enhancement/AY-5539_define-creators-per-task
Jun 10, 2024
+177
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Task linked: AY-5539 define creators per task |
BigRoy
reviewed
May 28, 2024
iLLiCiTiT
reviewed
May 28, 2024
iLLiCiTiT
reviewed
May 28, 2024
iLLiCiTiT
reviewed
May 28, 2024
iLLiCiTiT
reviewed
May 28, 2024
iLLiCiTiT
reviewed
May 28, 2024
iLLiCiTiT
reviewed
May 28, 2024
iLLiCiTiT
reviewed
May 28, 2024
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
…ancement/AY-5539_define-creators-per-task
…ors-per-task' into enhancement/AY-5539_define-creators-per-task
Safely return task_type only if task_entity exits.
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
…ors-per-task' into enhancement/AY-5539_define-creators-per-task
BigRoy
reviewed
May 31, 2024
BigRoy
reviewed
May 31, 2024
BigRoy
reviewed
May 31, 2024
Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>
BigRoy
reviewed
May 31, 2024
iLLiCiTiT
reviewed
May 31, 2024
iLLiCiTiT
reviewed
May 31, 2024
iLLiCiTiT
reviewed
May 31, 2024
MilaKudr
approved these changes
May 31, 2024
BigRoy
reviewed
Jun 3, 2024
re.compile might be expensive, do it outside of loop
BigRoy
reviewed
Jun 3, 2024
64qam
approved these changes
Jun 5, 2024
BigRoy
approved these changes
Jun 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't test the code, but overall the code changes look good. Might need some testing by someone still if it hasn't been thoroughly tested yet.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
This provides a way how to limit list of provided Creators in Publisher based on current context. This should
help artists decision which creator they should use.
Creator labels can by
copy&pasted
from Publisher.Additional info
If you want to limit which creators should be shown, provide some profile, based on host name and task info.
Put creator identifier to
Allowed Creator Labels
.Testing notes:
ayon+settings://core/tools/creator/filter_creator_profiles?project=ayon_test