Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing: Setup Playwright end-to-end testing and write first tests #432

Closed
3 tasks
Innders opened this issue May 17, 2024 · 4 comments · Fixed by #444
Closed
3 tasks

Testing: Setup Playwright end-to-end testing and write first tests #432

Innders opened this issue May 17, 2024 · 4 comments · Fixed by #444
Assignees
@Innders @flynput
Labels
type: maintenance Changes to the code that don't affect product functionality (Technical debt, refactors etc.))

Comments

@Innders
Copy link
Member

Innders commented May 17, 2024

Story

We make a small change in one area and accidently prevent new users from signing up. (This actually happened)

Problems

When something is merged we cannot guarantee that everything is still working just by clicking around the app, it is very easy to miss unintended side effects.

Proposal

We use Playwright as a testing library.

We start with critical tests only and add more overtime.

TODO

  • Install playwright
  • Create first few tests
  • Create a new ongoing issue documenting new tests that need to be written
@Innders Innders added the type: feature Adding something new and exciting to the product label May 17, 2024
@Innders Innders self-assigned this May 17, 2024
@Innders Innders added type: maintenance Changes to the code that don't affect product functionality (Technical debt, refactors etc.)) and removed type: feature Adding something new and exciting to the product labels May 17, 2024
Innders added a commit that referenced this issue May 20, 2024
@Innders
Testing: Setup Playwright end-to-end testing and write first tests
f64f16e 
Fixes #432
@Innders Innders linked a pull request May 20, 2024 that will close this issue
Testing: setup playwright and first basic end to end tests #444
Merged
Innders added a commit that referenced this issue Jun 24, 2024
@Innders
Testing: Setup Playwright end-to-end testing and write first tests
a2a5fcb 
Fixes #432
@gibsonliketheguitar
Copy link

@Innders Can I help with this?

@Innders
Copy link
Member Author

Innders commented Jul 9, 2024

Can I help with this?

Sure, feel free to contribute to this PR: #444

I had it all working and then at some point it stopped...

@dee-ynput
Copy link

@mkolar do we want to invest more time here?
Tests are important for the frontend team, but the business value is... mitigated 😝

Innders added a commit that referenced this issue Aug 7, 2024
@Innders
Testing: Setup Playwright end-to-end testing and write first tests
0606649 
Fixes #432
@mkolar
Copy link
Member

mkolar commented Aug 7, 2024

I'd say it's definitely worth it. without FE testing, we'll keep running into the same things again and again.

Innders added a commit that referenced this issue Aug 13, 2024
@Innders
Testing: Setup Playwright end-to-end testing and write first tests
553e0f6 
Fixes #432
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Innders Innders

@flynput flynput

Labels
type: maintenance Changes to the code that don't affect product functionality (Technical debt, refactors etc.))
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Testing: setup playwright and first basic end to end tests ynput/ayon-frontend
5 participants
@mkolar @Innders @gibsonliketheguitar @dee-ynput @flynput