fix: Use brighter colors for better accessibility #4
Conversation
|
I installed jnv using brew just now, but the color seems not changed? |
src/jnv.rs
Outdated
| @@ -74,16 +74,16 @@ impl Jnv { | |||
| history: Default::default(), | |||
| prefix: String::from("❯❯ "), | |||
| mask: Default::default(), | |||
| prefix_style: StyleBuilder::new().fgc(Color::DarkCyan).build(), | |||
| active_char_style: StyleBuilder::new().bgc(Color::DarkMagenta).build(), | |||
| prefix_style: StyleBuilder::new().fgc(Color::Cyan).build(), | |||
There was a problem hiding this comment.
@corneliusroemer I would like to proceed with the merge, but please make a revision just regarding this #3 (comment).
There was a problem hiding this comment.
Thanks for your feedback! I'm not quite sure what exactly I should change here, can you make that change? You should have push rights to the branch!
There was a problem hiding this comment.
I've just made a change, turning one of the Cyans into Blue so that each color is used only once again
|
@rrfeng This pull request is not yet merged. So the color theme is still v0.1.0 instead. |
Oh I missed the status of this pull request :D |
Cyan was used twice, use blue in one place instead (the one where readability is less crucial
|
I've updated the PR as requested @ynqa |
|
Excellent! Now just a new release 😎 |
Resolves #3
Replace all
Colors:DarkCOLORwithColors:COLORThe reason for the very dark colors before was the double darkening due to: a) background and b) dark version.
With this PR things are actually readable:
This is current
main: