Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-evaluate and optimize travis build #55

Closed
moorscode opened this issue Dec 20, 2017 · 4 comments
Closed

Re-evaluate and optimize travis build #55

moorscode opened this issue Dec 20, 2017 · 4 comments
Assignees

Comments

@moorscode
Copy link
Contributor

Following up on the comment placed on this PR: #52

We should re-evaluate if we can optimize the build script by only loading and configuring the elements we really need for a run.

@jrfnl
Copy link
Collaborator

jrfnl commented Dec 21, 2017

Side-note: something else which you may or may not want to address in this ticket:

The travis build for YoastCS itself uses the master branches of WPCS as well as PHPCompatibility to test the code style of the YoastCS code.
Those master branches are not necessarily the same as the versions defined in the composer.json file.
This could be synchronized by removing the git clones from the Travis script in favour of doing a composer install.
This will make the builds a little slower.

On the up-side: leaving things as they are, will mean that YoastCS has an "early warning" system in place for when the rulesets need updating.
In that case, it may be useful to configure a regular (monthly?) build in TravisCI to auto-run the build check independent of PRs.

@moorscode
Copy link
Contributor Author

I would suggest to keep that in place and just make sure that we only configure and load elements in the script that are really needed for specific builds instead of altering the builds that are being run.

@jrfnl
Copy link
Collaborator

jrfnl commented Dec 22, 2017

@moorscode I'm not sure I understand what you mean ... ?

@moorscode
Copy link
Contributor Author

I looked into it and it turned out I missed a bit of thinking.
It seems that the travis build is optimized already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants