Try to fix Casing issue in uri.path between formatted diagnostics and…

… hoverProvider #100
yoavbls · Apr 7, 2024 · 98b5291 · 98b5291
1 parent b388ac5
commit 98b5291
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 3 deletions.
diff --git a/examples/errors.vue b/examples/errors.vue
@@ -0,0 +1,12 @@
+<script setup lang="ts">
+import { RouterView } from "vue-router";
+
+const x = [1, 2, 3, "4"];
+
+function y(param: number[]) {}
+
+y(x);
+</script>
+<template>
+  <RouterView />
+</template>
diff --git a/src/extension.ts b/src/extension.ts
@@ -69,7 +69,7 @@ export function activate(context: ExtensionContext) {
             hasTsDiagnostic = true;
           });
 
-        uriStore[uri.path] = items;
+        uriStore[uri.fsPath] = items;
 
         if (hasTsDiagnostic) {
           const editor = window.visibleTextEditors.find(

diff --git a/src/format/embedSymbolLinks.ts b/src/format/embedSymbolLinks.ts
@@ -18,7 +18,7 @@ export function embedSymbolLinks(diagnostic: Diagnostic): Diagnostic {
     ...diagnostic,
     message: diagnostic.message.replaceAll(
       symbol,
-      `${symbol} <a href="${URI.parse(ref.location.uri).path}#${
+      `${symbol} <a href="${URI.parse(ref.location.uri).fsPath}#${
         ref.location.range.start.line + 1
       },${
         ref.location.range.start.character + 1

diff --git a/src/provider/hoverProvider.ts b/src/provider/hoverProvider.ts
@@ -3,7 +3,7 @@ import { uriStore } from "./uriStore";
 
 export const hoverProvider: HoverProvider = {
   provideHover(document, position) {
-    const itemsInUriStore = uriStore[document.uri.path];
+    const itemsInUriStore = uriStore[document.uri.fsPath];
 
     if (!itemsInUriStore) {
       return null;