You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
/*** Returns a string representing the corresponding file system path of this URI.* Will handle UNC paths, normalizes windows drive letters to lower-case, and uses the* platform specific path separator.** * Will *not* validate the path for invalid characters and semantics.* * Will *not* look at the scheme of this URI.* * The result shall *not* be used for display purposes but for accessing a file on disk.*** The *difference* to `URI#path` is the use of the platform specific separator and the handling* of UNC paths. See the below sample of a file-uri with an authority (UNC path).*/
The text was updated successfully, but these errors were encountered:
* Try to fix Casing issue in uri.path between formatted diagnostics and hoverProvider #100
* Add ts-plugin diagnostic source for Vue Hybrid mode
* Bump version
Thank you for the detailed issue!
I think the main reason it didn't work is that In the new official extension of Vue VSCode plugin, Hybrid mode is enabled by default, which means that a TypeScript LSP Plugin publishes the diagnostics as ts-plugin instead of ts.
I fixed it in #103, published in v0.5.4.
I also moved to fsPath. It is better, and I wasn't aware of that. Thank you!
Describe the bug
I noticed that I did not get any prettified errors when working from a
.vue
file.I setup a basic snippet like:
And per screenshot the highlighter result:
Expected behavior
I expected to see a prettified error message as vue support is implemented.
Cause
I cloned the repo and ran it with the debugger and found that this issue is caused by the following:
pretty-ts-errors/src/extension.ts
Line 72 in b388ac5
On this line the value of
uri.path
is:'/c:/Users/kevin/Documents/Projects/phavuer-playground/src/App.vue'
When in the
hoverProvider.ts
:pretty-ts-errors/src/provider/hoverProvider.ts
Lines 6 to 10 in b388ac5
The value of
document.uri.path
is'/C:/Users/kevin/Documents/Projects/phavuer-playground/src/App.vue'
.Notice the casing difference of the
C
drive:This causes the
hoverProvider
to think there are no stored items to show, and thus show no results.Fix
VS Code seems to use this implementation for the
Uri
class.Maybe use
fsPath
instead as it states:The text was updated successfully, but these errors were encountered: