Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split DD_TAGS by spaces and commas #31

Merged
merged 1 commit into from
Apr 7, 2021

Conversation

radiantnode
Copy link
Contributor

The DataDog documentation shows the tags as being delimited by commas. To support their documentation and backwards compatibility this plugin should support spaces and commas.

Copy link
Owner

@yob yob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

is the | intended to be an "OR"? I'm not the most confident with regular expressions, but I'd probably have gone with "[\s+,]" - do you know if there's a significant difference in the two approaches?

@radiantnode
Copy link
Contributor Author

@yob for single characters both syntaxes work the same way. The or operator can support multiple characters.

@yob
Copy link
Owner

yob commented Apr 7, 2021

ahhh, TIL. Thanks!

@yob yob merged commit 5f048d2 into yob:main Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants