Added if-modified-since header and updated url #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Getting super unlucky with travis builds :( sometimes they pass because 4Chan will return threads, and other times.. not so much. |
|
Great fixes! Can you break out the request options object into its own variable? |
|
Like that? |
|
perfect - nice job! |
yocontra
added a commit
that referenced
this pull request
Dec 6, 2013
Added if-modified-since header and updated url
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/4chan/4chan-API#api-rules requires the use of 'If-Modified-Since' in each request to their server.
http://www.ietf.org/rfc/rfc2616.txt section 4.2 states that http header field names are case insensitive so I added the header in allow lower-case.