Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImportError: No module named config #62

Closed
barrybarrette opened this issue Dec 14, 2017 · 5 comments
Closed

ImportError: No module named config #62

barrybarrette opened this issue Dec 14, 2017 · 5 comments

Comments

@barrybarrette
Copy link

I forked, cloned, and followed the steps of making the venv and installing requirements with pip. There were no errors reported during the installation of requirements. When I run yoda I get an ImportError stating that there is no config module. I had to copy config.py(c) from the project root into the site-packages\modules folder. I then had the same issue with util.py(c). After that I was able to run yoda successfully.

As an aside, I find it unusual to see a package like this where you install the 'production' code and execute it i.e. pip install . I think it would be an improvement to move the dependencies to requirements.txt and have the instructions simply call out pip install -r requirements.txt. The problem this causes for me anyway, maybe I'm missing something obvious, is that when i make a change to the project code, I do not see that reflected by running yoda. It is also not obvious to me where the entry point of the app is if, for example, i wanted to run it from within my IDE or from the command line with python <filename>.py.

What are the steps to reproduce this issue?

  1. Make virtualenv
  2. pip install .
  3. yoda

What happens?

File "c:\users\barry\pycharmprojects\yoda\venv\yoda\lib\site-packages\modules\setup.py", line 13, in <module> from config import get_config_file_paths ImportError: No module named config

What were you expecting to happen?

For yoda to run normally

What versions of software are you using?

Operating System: Windows 7 Ultimate 64 bit
Python version: 2.7

@drugones
Copy link

drugones commented Feb 2, 2018

Same issue here on osx.

@tterb
Copy link

tterb commented Feb 4, 2018

I'm also having this issue on macOS 10.12

@ctrlsam
Copy link

ctrlsam commented Feb 5, 2018

Couldn't the "config" library just be added to the requirements.txt so that when users initially run pip install -r requirements.txt that It would download this missing package?
I haven't properly looked at the project, just stumbled across this issue, so I apologize If my suggestion is wrong.

@manparvesh
Copy link
Member

@sillysam config.py is actually a file in the root folder of this project, so what you're suggesting is infeasible. I'll investigate the cause.

manparvesh added a commit that referenced this issue Feb 5, 2018
refs #62 move util.py and config.py into modules
@manparvesh
Copy link
Member

manparvesh commented Feb 5, 2018

@whitebarry @drugones @jonsn0w @sillysam
Thanks for reporting the issue and for the suggestions. I have fixed the issue in #73, so I will close this issue

@manparvesh manparvesh added this to the 18.02 milestone Feb 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants