Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infer city + country from IP #139

Merged

Conversation

AlexandruValeanu
Copy link
Contributor

@AlexandruValeanu AlexandruValeanu commented Oct 1, 2018

Short description of what this resolves:

Infer city + country from IP (from the TODO list)

Changes proposed in this pull request:

  • Add 'GeoLite2-City.mmdb' database
  • Add iplookup function
  • Add test for iplookup

@codecov-io
Copy link

codecov-io commented Oct 1, 2018

Codecov Report

Merging #139 into master will increase coverage by 0.3%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #139     +/-   ##
=========================================
+ Coverage   74.02%   74.32%   +0.3%     
=========================================
  Files          32       33      +1     
  Lines        2252     2275     +23     
=========================================
+ Hits         1667     1691     +24     
+ Misses        585      584      -1
Impacted Files Coverage Δ
modules/dev.py 76% <100%> (+2.31%) ⬆️
tests/dev/test_iplookup.py 100% <100%> (ø)
yoda.py 100% <100%> (ø) ⬆️
modules/util.py 73.33% <0%> (+1.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b89fd06...680d1b3. Read the comment docs.

@manparvesh
Copy link
Member

@AlexandruValeanu
Thanks a lot for contributing! 😄 I'm merging this.

@manparvesh manparvesh merged commit 0c58d93 into yoda-pa:master Oct 1, 2018
@manparvesh manparvesh mentioned this pull request Oct 1, 2018
2 tasks
@AlexandruValeanu AlexandruValeanu deleted the feature/IP_lookup_country branch October 1, 2018 17:55
@manparvesh manparvesh added this to the v1.0.0 milestone Oct 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants