Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint: covers src/benchmark/samples #410

Merged
merged 2 commits into from
Nov 9, 2018
Merged

lint: covers src/benchmark/samples #410

merged 2 commits into from
Nov 9, 2018

Conversation

legendecas
Copy link
Contributor

  • npm test passes

@legendecas legendecas changed the title lint: enables eslint on src/js/iotjs.js lint: covers src/benchmark/samples Nov 9, 2018
Copy link
Member

@yorkie yorkie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR, LGTM infinitely 👍

@yorkie yorkie merged commit af085cf into master Nov 9, 2018
@yorkie yorkie deleted the lint/iotjs branch November 9, 2018 10:47
yorkie pushed a commit that referenced this pull request Nov 10, 2018
@yorkie yorkie mentioned this pull request Nov 10, 2018
yorkie pushed a commit that referenced this pull request Nov 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants