Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

You cannot make cult golems unless you are cult #10129

Merged
merged 1 commit into from Oct 27, 2020

Conversation

ynot01
Copy link
Contributor

@ynot01 ynot01 commented Oct 23, 2020

Intent of your Pull Request

Only one with forbidden knowledge could hope to work this metal...

tested and working

Changelog

馃啈
tweak: You can no longer make cult golems unless you are cult
/:cl:

@Yogbot-13 Yogbot-13 added the Tweak This PR contains changes to the game. label Oct 23, 2020
@AdamElTablawy
Copy link
Contributor

why

@ynot01
Copy link
Contributor Author

ynot01 commented Oct 23, 2020

why

non-cultists should not have access to overpowered cult material, the same reason noncultists cannot use cult metal or other cult gear

@boodaliboo
Copy link
Contributor

why? i understand cult golem but not clock golem

@Marmio64
Copy link
Contributor

i wouldn't say either of these are OP. Sure they are powerful, but do they need to be removed from random players? However, if this is added i'll probably add a way to sell cult metal in cargo (if you can't already, i dont know) so that it isn't totally useless.

Copy link
Contributor

@jcatjmeow jcatjmeow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine to me

@Hopekz
Copy link
Contributor

Hopekz commented Oct 23, 2020

While not "OP" it seems like an oversight.
I don't think people can use cult metals normally to make things so it seems like inconsistent behavior to keep this in.

@UselessTheremin
Copy link
Contributor

Sad cogger noises

@AdamElTablawy
Copy link
Contributor

@ynot01 @Hopekz it is neither OP nor an oversight

it was very much intended behavior

much like the chaplain can create crew-sided constructs (which is intended) if they get their hands on a construct shell and a purified soulstone xenobiology can create runic golems if the crew recovers runed metal

@AdamElTablawy
Copy link
Contributor

also the PR that added runic golems intentionally specified they were meant to look culty but not be necessarily cult sided

@Hopekz
Copy link
Contributor

Hopekz commented Oct 24, 2020

also the PR that added runic golems intentionally specified they were meant to look culty but not be necessarily cult sided

Are you referring to this PR?
tgstation/tgstation#25028

That PR is on TG.
We have not had this discussion yet on yogs. The PR that added the runic golems to yogs also didn't mention anything like that.

Remember; we are not TG so what might be intentional there might not be intentional here as it was added here in the form of a lazy port without any real discussion, making it a potential oversight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tweak This PR contains changes to the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants